Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPFS resolve method ASK for dnslink redirects #15263

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Sep 28, 2022

Resolves brave/brave-browser#25406
Use ipfs:// scheme instead of gateway url

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test dnslink redirect and redirect from address bar ipfs button when IPFS resolve method is ASK

@cypt4 cypt4 requested a review from yrliou September 28, 2022 20:24
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just an outdated comment and a missing unit test.

browser/ipfs/ipfs_tab_helper.cc Show resolved Hide resolved
components/ipfs/ipfs_utils.cc Show resolved Hide resolved
@cypt4 cypt4 merged commit 37213c3 into master Oct 3, 2022
@cypt4 cypt4 deleted the brave_25406 branch October 3, 2022 11:20
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show IPFS button and do DNSLink redirects when IPFS Resolution method is setted up as ASK
2 participants