Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when user starts a new sync chain the modal needs to prevent cancelation #2564

Closed
cezaraugusto opened this issue Dec 14, 2018 · 6 comments · Fixed by brave/brave-core#1193
Closed

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Dec 14, 2018

Test plan

See brave/brave-core#1193

Description

  1. Clear profile
  2. Click "start a new sync chain"
  3. Click "tablet or phone"
  4. Try to cancel the modal
  5. A new modal appears asking if you are sure about closing it
@LaurenWags
Copy link
Member

@cezaraugusto does this refer to the following scenario:
Start sync chain on device A
Enter code words on device B
Device B "completes" joining the sync chain (meaning, the screen where words were entered closes automatically to show the page which lists devices).
Device A still hasn't completed (recognized the chain has been created?) and the screen showing the words is still displayed.
User thinks they have to close this window manually on Device A, so they do and now the chain is seemingly lost?

....asking because I just did this.

@cezaraugusto
Copy link
Contributor Author

hey @LaurenWags yes, correct. Added QA/no label as it shouldn't change the current flow but will change the application logic.

@cezaraugusto
Copy link
Contributor Author

moving to 0.59 per last sync meeting

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 20, 2018
@bbondy bbondy modified the milestones: 0.59.x - Beta, 1.x Backlog Dec 20, 2018
@rossmoody
Copy link
Contributor

The most up to date design spec for Sync can be found right here.

@cezaraugusto cezaraugusto changed the title when user starts a new sync chain the modal needs to disable cancelation when user starts a new sync chain the modal needs to prevent cancelation Jan 2, 2019
@cezaraugusto
Copy link
Contributor Author

changing to QA/yes as it has valid steps to check the new feature

@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants