-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Children of Sync device type modal should use the same modal #2677
Milestone
Comments
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 1, 2019
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 2, 2019
setting this as QA/no since this is expected behavior and didn't add new features |
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 2, 2019
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 3, 2019
Changed the label to QA/Yes after talking to @kjozwiak. |
Verification passed on
Used test plan from brave/brave-core#1193. For convenience I included the test plan below:
Verification passed on Ubuntu 17.10
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test plan
See brave/brave-core#1193
Description
carried over from #2500
Device type modal opens a new modal every time user choose either desktop or mobile versions. This is bad UI and should be fixed using only 1 modal with dynamic content.
Test Plan:
What happens: You have to click "ok" several times before modal is closed
What should happen: Clicking "ok" should close all dialogs
The text was updated successfully, but these errors were encountered: