Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding is too small between Word Code and QR Code in view sync code modal #2591

Closed
btlechowski opened this issue Dec 17, 2018 · 5 comments · Fixed by brave/brave-core#1193
Closed

Padding is too small between Word Code and QR Code in view sync code modal #2591

btlechowski opened this issue Dec 17, 2018 · 5 comments · Fixed by brave/brave-core#1193
Assignees
@cezaraugusto @rossmoody
Labels
feature/sync priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@btlechowski
Copy link

btlechowski commented Dec 17, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1193

Steps to Reproduce

  1. Sync two devices
  2. In Desktop Browser click view sync code

Actual result:

Padding is too small between Word Code and QR Code
image

Expected result:

Example:
image

Brave version (brave://version info)

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

@cezaraugusto @bradleyrichter @brave/legacy_qa
@btlechowski btlechowski added this to the 0.58.x - Release milestone Dec 17, 2018
@btlechowski btlechowski mentioned this issue Dec 17, 2018
Closed
@kjozwiak
Copy link
Member

Reproducible on macOS 10.14 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2018-12-17 at 11 50 54 am

Would be nice to fix before this before 0.58.x goes out the door with sync enabled, but definitely not a blocker/critical.

@cezaraugusto
Copy link
Contributor

cc @rossmoody

@cezaraugusto
Copy link
Contributor

moving to 0.59 per last sync meeting

@cezaraugusto cezaraugusto self-assigned this Dec 19, 2018
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 20, 2018
@bbondy bbondy modified the milestones: 0.59.x - Beta, 1.x Backlog Dec 20, 2018
@rossmoody
Copy link
Contributor

The most up to date design spec for Sync (that addresses this design polish) can be found right here.

cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 1, 2019
@cezaraugusto
update spec of sync devices/qr code/words modals
7d8718e 
close brave/brave-browser#2724
close brave/brave-browser#2591
address brave/brave-browser#2567
@cezaraugusto cezaraugusto mentioned this issue Jan 1, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
update spec of sync devices/qr code/words modals
7731052 
close brave/brave-browser#2724
close brave/brave-browser#2591
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto
update spec of sync devices/qr code/words modals
abd7595 
close brave/brave-browser#2724
close brave/brave-browser#2591
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux
  • View Sync code only shows either Code words/QR code as per new UI

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows
  • View Sync code only shows either Code words/QR code as per new UI

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

@rossmoody rossmoody

Labels
feature/sync priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix multiple sync issues brave/brave-core
9 participants
@bbondy @kjozwiak @cezaraugusto @bsclifton @srirambv @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya