-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "view sync code" to "view QR code and Code words" followup to #2549 #2595
Labels
feature/sync
polish
Nice to have — usually related to front-end/visual tasks
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
srirambv
added
polish
Nice to have — usually related to front-end/visual tasks
feature/sync
release/not-blocking
QA/Yes
release-notes/exclude
design/needs-text
labels
Dec 17, 2018
moving to 0.59 per last sync meeting |
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Dec 17, 2018
brave/brave-browser#2595 - button is localed in the right-hand side of devices table
@cezaraugusto Issue still persists on 0.59.12, Is this not yet merged in 0.59.12? |
Verification passed on
Verification passed on Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit) Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/sync
polish
Nice to have — usually related to front-end/visual tasks
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Description
"view sync code" might not be descriptive enough and might confuse with "add device" functionality. Renaming it to "view QR code and Code words" should make it more easy to differentiate the functionalities of both buttons.
Actual result:
The text was updated successfully, but these errors were encountered: