Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync QR code and words should only show when data is fetched #2604

Closed
cezaraugusto opened this issue Dec 17, 2018 · 1 comment · Fixed by brave/brave-core#1115
Closed

Sync QR code and words should only show when data is fetched #2604

cezaraugusto opened this issue Dec 17, 2018 · 1 comment · Fixed by brave/brave-core#1115
Labels
closed/wontfix feature/sync fixed-with-sync-v2 QA/No release-notes/exclude

Comments

@cezaraugusto
Copy link
Contributor

Similar to #2602. Sync should only render data-driven components if data already exists.

Setting as QA/no as this does not change any test plan and claim is an expected behavior.
@cezaraugusto cezaraugusto added this to the 0.59.x - Beta milestone Dec 17, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 17, 2018
Merged
@kjozwiak kjozwiak mentioned this issue Jan 3, 2019
Closed
@cezaraugusto
Copy link
Contributor Author

re-opening after brave/brave-core#1193 (comment)

@cezaraugusto cezaraugusto reopened this Jan 4, 2019
@cezaraugusto cezaraugusto modified the milestones: 0.59.x - Beta, 1.x Backlog Jan 4, 2019
@cezaraugusto cezaraugusto mentioned this issue Jan 4, 2019
Merged
@cezaraugusto cezaraugusto reopened this Jan 14, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@cezaraugusto cezaraugusto removed their assignment Mar 3, 2020
@rebron rebron moved this to Completed in Sync - All platforms Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix feature/sync fixed-with-sync-v2 QA/No release-notes/exclude
Projects
Sync - All platforms
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync: ensure qr code and words are shown only when data is fetched brave/brave-core
4 participants
@jsecretan @bbondy @cezaraugusto @rebron