Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: ensure qr code and words are shown only when data is fetched #1115

Merged
merged 1 commit into from
Dec 18, 2018
Merged

sync: ensure qr code and words are shown only when data is fetched #1115

merged 1 commit into from
Dec 18, 2018

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#2604
fix brave/brave-browser#2602

Test Plan:

  1. Have Sync disabled
  2. As fast as you can, go to "device type" modal
  3. Click "desktop" icon button
  4. You should see the code words textarea field rendering with words and not empty
  5. Return to step 1 and repeat operation, this time with "mobile" icon button
  6. You should see the QR code rendering properly
  7. Sync another device
  8. With Sync enabled, open "view sync code" (right-hand side button)
  9. Modal should show the Sync code
  10. Return from the modal
  11. With Sync still enabled, open "add device" (right-hand side button)
  12. You should see the QR code and code words loading instantly

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
darkdh
darkdh approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 8848f33 into master Dec 18, 2018
@cezaraugusto cezaraugusto deleted the ca-2604 branch December 18, 2018 14:20
cezaraugusto added a commit that referenced this pull request Dec 18, 2018
@cezaraugusto
Merge pull request #1115 from brave/ca-2604
eac195c 
sync: ensure qr code and words are shown only when data is fetched
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Dec 18, 2018 •
edited by darkdh
Loading

master 8848f33
0.60.x eac195c
0.59.x 371e50e

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh pushed a commit that referenced this pull request Dec 20, 2018
@cezaraugusto @darkdh
Merge pull request #1115 from brave/ca-2604
371e50e 
sync: ensure qr code and words are shown only when data is fetched
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Dec 26, 2018
Closed
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Sync QR code and words should only show when data is fetched Sync I have code words modal doesn't show words
4 participants
@cezaraugusto @rebron @darkdh @bbondy