-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update search engine defaults for BR / AR #26181
Comments
Maybe we also want NTP search promotion to these new regions |
We probably need to re-open this for Android as I'm not sure if the work is done yet. |
@anthonypkeane setting brave as default should be good but we need to change the onboarding behaviour for android. |
This issue was closed incorrectly as the work on Android was not completed. Reopening, adding the correct Android project and assigning to @deeppandya & @timchilds |
@anthonypkeane the issue has an associated PR so it should not be reopened. If we need we can add an Android specific issue and mark this one as Desktop only |
The above requires |
This particular PR can be verified on
|
Verification
|
Brave | 1.45.121 Chromium: 107.0.5304.91 (Official version) (x86_64) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | macOS Version 11.7.1 (Compiled 20G918) |
BR (Brazilian) locale
(new addition)
Case #1
- #26182
brave://welcome
Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen
was removed from brave://welcome
as per the following:
Example |
Example |
Example |
---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Brave
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Google/Brave)
- installed
1.45.118
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured thatGoogle
is still the default SE forNormal Windows
- ensured that
Google
wasn't replaced byBrave
forNormal
windows
- ensured that
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (DDG/Startpage)
- installed
1.45.118
- ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (Qwant/Bing)
- installed
1.45.118
- ensured that
Qwant
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Bing
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
DE (German) locale
(existing locale with Brave Search as default)
Case #1
- #26182
brave://welcome
Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen
was removed from brave://welcome
as per the following:
Example |
Example |
Example |
---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Brave
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Brave/Brave)
- installed
1.45.118
- ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured thatBrave
is still the default SE forNormal
&PB
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (DDG/Startpage)
- installed
1.45.118
- ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
JP (Japan) locale
(doesn't have Brave Search as default)
Case #1
- #26182
brave://welcome
Ensured that the Set default search engine screen
was was still present via brave://welcome
as per the following:
Example |
Example |
Example |
Example |
---|---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Google
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Google/Brave)
- installed
1.45.118
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured thatGoogle
is still the default SE forNormal
windows - ensured that
Brave
is still the default SE forPrivate
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (Startpage/Bing)
- installed
1.45.118
- ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Bing
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
RU (Russia) locale
(Yandex as the default SE)
Case #1
- #26182
brave://welcome
Ensured that the Set default search engine screen
was was still present via brave://welcome
as per the following:
Example |
Example |
Example |
Example |
---|---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Yandex
was selected as the default for Normal windows viabrave://settings/searchEngines
- ensured that
Brave
was selected as the default for Private windows viabrave://settings/searchEngines
Example |
Example |
Example |
---|---|---|
Updated Profile (Yandex/Brave)
- installed
1.45.118
- ensured that
Yandex
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.46.96
and ensured thatYandex
is still the default SE forNormal
windows - ensured that
Brave
is still the default SE forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example |
Example |
---|---|
Updated Profile (Google/DDG)
- installed
1.45.118
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
1.45.118 |
1.45.121 |
---|---|
Example |
Example |
---|---|
Verification PASSED on
|
Example |
Example |
Example |
---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Brave
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Google/Brave)
- installed
1.47.20 Chromium: 107.0.5304.68
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.47.36 Chromium: 107.0.5304.91
and ensured thatGoogle
is still the default SE forNormal Windows
- ensured that
Google
wasn't replaced byBrave
forNormal
windows
- ensured that
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.47.20 Chromium: 107.0.5304.68 |
1.47.36 Chromium: 107.0.5304.91 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (DDG/Startpage)
- installed
1.45.118
- ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (Qwant/Bing)
- installed
1.45.118
- ensured that
Qwant
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Bing
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
FR (France) locale
(existing locale with Brave Search as default)
Case #1
- #26182
brave://welcome
Using the STR/Cases outlined via #26182 (comment) and ensured that the Set default search engine screen
was removed from brave://welcome
as per the following:
Example |
Example |
Example |
---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Brave
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Brave/Brave)
- installed
1.45.118
- ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121 Chromium: 107.0.5304.91
and ensured thatBrave
is still the default SE forNormal
&PB
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (DDG/Startpage)
- installed
1.45.118
- ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
IN (India) locale
(doesn't have Brave Search as default)
Case #1
- #26182
brave://welcome
Ensured that the Set default search engine screen
was was still present via brave://welcome
as per the following:
Example |
Example |
Example |
Example |
---|---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Google
was selected as the default for both Normal/Private windows viabrave://settings/searchEngines
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Google/Brave)
- installed
1.45.118
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured thatGoogle
is still the default SE forNormal
windows - ensured that
Brave
is still the default SE forPrivate
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
Updated Profile (Startpage/Bing)
- installed
1.45.118
- ensured that
Startpage
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Bing
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example (Brave at top of list) |
Example (Brave at top of list) |
---|---|
RU (Russia) locale
(Yandex as the default SE)
Case #1
- #26182
brave://welcome
Ensured that the Set default search engine screen
was was still present via brave://welcome
as per the following:
Example |
Example |
Example |
Example |
---|---|---|---|
Case #2
- #26181
Clean Profile
- ensured that
Yandex
was selected as the default in Normal windows viabrave://settings/searchEngines
- ensured that
Brave
was selected as the default in Private windows viabrave://settings/searchEngines
- ensured that
Yandex
was the first engine via the drop down list underbrave://settings/searchEngines
forNormal
windows - ensured that
Yandex
was the first engine via the drop down list underbrave://settings/searchEngines
forPrivate
windows
Example |
Example |
Example |
---|---|---|
Updated Profile (Yandex/Brave)
- installed
1.45.118
- ensured that
Yandex
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
Brave
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured thatYandex
is still the default SE forNormal
windows - ensured that
Brave
is still the default SE forPrivate
windows
1.45.118 |
1.45.121 |
---|---|
Example |
Example |
---|---|
Updated Profile (Google/DDG)
- installed
1.45.118
- ensured that
Google
was the default SE selected underbrave://settings/searchEngines
forNormal
windows - ensured that
DDG
was the default SE selected underbrave://settings/searchEngines
forPrivate
windows - updated to
1.45.121
and ensured that both SE engines were still selected as the default- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
1.45.118 |
1.45.121 |
---|---|
Example |
Example |
---|---|
Verification passed on
|
Description
Update search engine defaults for:
Brave should be at the top of drop down list at brave://settings/search
Related: #18331 and #23814
Test plan
Region set to BR / AR
Default search engines
listRegion set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX)
Default search engines
list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.Notes for test plan
#23814 (comment)
The text was updated successfully, but these errors were encountered: