Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove set default search engine screen for BR / AR #15669

Merged
merged 1 commit into from
Oct 26, 2022
Merged

remove set default search engine screen for BR / AR #15669

merged 1 commit into from
Oct 26, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 26, 2022 •
edited
Loading

Resolves brave/brave-browser#26182
Resolves brave/brave-browser#26181

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from issue

@spylogsster spylogsster requested a review from bsclifton October 26, 2022 09:01
@spylogsster spylogsster requested a review from a team as a code owner October 26, 2022 09:01
@spylogsster spylogsster self-assigned this Oct 26, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton
Copy link
Member

@spylogsster this also fixes brave/brave-browser#26181 right?

iefremov
iefremov approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src lgtm

bsclifton
bsclifton approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to link to brave/brave-browser#26181 as the new defaults are set in this PR too (ex: this PR doesn't only remove default screen, it also changes default)

But changes LGTM! 😄 👍

@spylogsster spylogsster merged commit c63c27a into master Oct 26, 2022
@spylogsster spylogsster deleted the brave-26182 branch October 26, 2022 17:49
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 26, 2022
@spylogsster spylogsster restored the brave-26182 branch October 26, 2022 18:34
@brave-builds brave-builds mentioned this pull request Oct 26, 2022
Merged
7 tasks
brave-builds pushed a commit that referenced this pull request Oct 26, 2022
@brave-browser-releases
Uplift of #15669 (squashed) to beta
bfd4fd7
spylogsster added a commit that referenced this pull request Oct 26, 2022
@spylogsster
remove set default search engine screen for BR / AR (#15669)
542f9b2 
remove default search engine screen

(cherry picked from commit c63c27a)
@spylogsster spylogsster mentioned this pull request Oct 26, 2022
Merged
7 tasks
@spylogsster spylogsster deleted the brave-26182 branch November 1, 2022 10:15
@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2022 •
edited
Loading

Desktop verification

Verification PASSED on Win 10 x64 VM using the following build(s):

Brave | 1.47.36 Chromium: 107.0.5304.91 (Official build) nightly 64 bits
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 22H2 (Build 19045.2193)

BR (Brazil) locale (new addition)

Case #1 - brave/brave-browser#26182

brave://welcome

Using the STR/Cases outlined via brave/brave-browser#26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for Normal Windows
    • ensured that Google wasn't replaced by Brave for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Startpage/DDG)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Bing/Qwant)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

AR (Argentina) locale (new addition)

Case #1 - brave/brave-browser#26182

brave://welcome

Using the STR/Cases outlined via brave/brave-browser#26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Google/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for Normal Windows
    • ensured that Google wasn't replaced by Brave for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (DDG/Startpage)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Qwant/Bing)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

FR (France) locale (existing locale with Brave Search as default)

Case #1 - brave/brave-browser#26182

brave://welcome

Using the STR/Cases outlined via brave/brave-browser#26182 (comment) and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

Example Example Example
image image image

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image image image
Updated Profile (Brave/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Brave is still the default SE for Normal & PB windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (DDG/Startpage)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

JP (Japan) locale (doesn't have Brave Search as default)

Case #1 - brave/brave-browser#26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
image image image image

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
image) image image
Updated Profile (Google/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image
Updated Profile (Startpage/Bing)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example (Brave at top of list) Example (Brave at top of list)
image image

RU (Russia) locale (Yandex as the default SE)

Case #1 - brave/brave-browser#26182

brave://welcome

Ensured that the Set default search engine screen was was still present via brave://welcome as per the following:

Example Example Example Example
image image image image

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Yandex was selected as the default for both Normal/Private windows via brave://settings/searchEngines
Example Example Example
image image image
Updated Profile (Yandex/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Yandex is still the default SE for Normal windows
  • ensured that Brave is still the default SE for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example Example
image image
Updated Profile (Google/DDG)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
image image
Example Example
image image

@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2022 •
edited
Loading

Android verification

As per brave/brave-browser#26318 (comment), the onboarding part of the verification will be completed once @deeppandya fixes/addresses brave/brave-browser#26318.

Verification PASSED on Samsung Galaxy S10+ running Android using the following build(s):

Brave | 1.47.36 Chromium: 107.0.5304.91 (Official build) canary (32 bits)
--- | ---
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Android 12; Build/SP1A.210812.016

BR (Brazil) locale (new addition)

Case #1 - brave/brave-browser#26318

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Screenshot_20221102-011741_Brave - Nightly Screenshot_20221102-011745_Brave - Nightly Screenshot_20221102-011749_Brave - Nightly
Updated Profile (Google/Google)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for both Normal & PB windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for both windows
    • ensured that Google wasn't replaced by Brave for Normal or Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221102-015220_Brave - Nightly Screenshot_20221102-015257_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221102-015301_Brave - Nightly Screenshot_20221102-015306_Brave - Nightly
Updated Profile (Qwant/Bing)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Qwant is still the default SE for Normal windows
  • ensured that Bing is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221102-020007_Brave - Nightly Screenshot_20221102-020042_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221102-020046_Brave - Nightly Screenshot_20221102-020051_Brave - Nightly
Updated Profile (Startpage/DDG)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Startpage is still the default SE for Normal windows
  • ensured that DDG is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221102-021059_Brave - Nightly Screenshot_20221102-021217_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221102-021221_Brave - Nightly Screenshot_20221102-021226_Brave - Nightly

AR (Argentina) locale (new addition)

Case #1 - brave/brave-browser#26318

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Screenshot_20221103-150148_Brave - Nightly Screenshot_20221103-150152_Brave - Nightly Screenshot_20221103-150157_Brave - Nightly
Updated Profile (Google/Google)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for both Normal & PB windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for both windows
    • ensured that Google wasn't replaced by Brave for Normal or Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-145605_Brave - Nightly Screenshot_20221103-145729_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-145618_Brave - Nightly Screenshot_20221103-145623_Brave - Nightly
Updated Profile (Qwant/DDG)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Qwant is still the default SE for Normal windows
  • ensured that DDG is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-151256_Brave - Nightly Screenshot_20221103-151324_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-151328_Brave - Nightly Screenshot_20221103-151333_Brave - Nightly
Updated Profile (Bing/Startpage)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Bing is still the default SE for Normal windows
  • ensured that Startpage is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-150732_Brave - Nightly Screenshot_20221103-150651_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-150736_Brave - Nightly Screenshot_20221103-150740_Brave - Nightly

FR (France) locale (existing locale with Brave Search as default)

Case #1 - brave/brave-browser#26318

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Screenshot_20221103-152436_Brave - Nightly Screenshot_20221103-152441_Brave - Nightly Screenshot_20221103-152446_Brave - Nightly
Updated Profile (Brave/Brave)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Brave is still the default SE for Normal & PB windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-152829_Brave - Nightly Screenshot_20221103-152907_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-152910_Brave - Nightly Screenshot_20221103-152918_Brave - Nightly
Updated Profile (Bing/Qwant)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Bing was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-154038_Brave - Nightly Screenshot_20221103-154105_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-154110_Brave - Nightly Screenshot_20221103-154114_Brave - Nightly

PL (Poland) locale (doesn't have Brave Search as default)

Case #1 - brave/brave-browser#26318

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Google was selected as the default for both Normal/Private windows via brave://settings/searchEngines
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
Example Example Example
Screenshot_20221103-155350_Brave - Nightly Screenshot_20221103-155401_Brave - Nightly Screenshot_20221103-155405_Brave - Nightly
Updated Profile (Google/Google)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Google was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Google is still the default SE for Normal windows
  • ensured that Google is still the default SE for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-155656_Brave - Nightly Screenshot_20221103-155840_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-155844_Brave - Nightly Screenshot_20221103-155848_Brave - Nightly
Updated Profile (Qwant/Startpage)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Qwant was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/searchEngines for Private windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-160358_Brave - Nightly Screenshot_20221103-160444_Brave - Nightly
Example (Brave at top of list) Example (Brave at top of list)
Screenshot_20221103-160401_Brave - Nightly Screenshot_20221103-160406_Brave - Nightly

RU (Russia) locale (Yandex as the default SE)

Case #1 - brave/brave-browser#26318

Case #2 - brave/brave-browser#26181

Clean Profile
  • ensured that Yandex was selected as the default for both Normal/Private windows via brave://settings/searchEngines
Example Example Example
Screenshot_20221103-161348_Brave - Nightly Screenshot_20221103-161353_Brave - Nightly Screenshot_20221103-161357_Brave - Nightly
Updated Profile (Yandex/Yandex)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Yandex was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that Yandex is still the default SE for Normal & PB windows
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-161728_Brave - Nightly Screenshot_20221103-161754_Brave - Nightly
Example Example
Screenshot_20221103-161757_Brave - Nightly Screenshot_20221103-161801_Brave - Nightly
Updated Profile (DDG/Startpage)
  • installed 1.47.20 Chromium: 107.0.5304.68
  • ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows
  • ensured that Startpage was the default SE selected under brave://settings/searchEngines for Private windows
  • updated to 1.47.36 Chromium: 107.0.5304.91 and ensured that both SE engines were still selected as the default
    • ensured that it wasn't replaced by Brave
1.47.20 Chromium: 107.0.5304.68 1.47.36 Chromium: 107.0.5304.91
Screenshot_20221103-162049_Brave - Nightly Screenshot_20221103-162114_Brave - Nightly
Example Example
Screenshot_20221103-162122_Brave - Nightly Screenshot_20221103-162118_Brave - Nightly

@kjozwiak kjozwiak mentioned this pull request Nov 2, 2022
Closed
kjozwiak added a commit that referenced this pull request Nov 4, 2022
@kjozwiak
Merge pull request #15677 from brave/15669_uplift_to_1.45.x
f67c6f6 
(uplift to 1.45.x) remove set default search engine screen for BR / AR (#15669)
This was referenced Nov 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@iefremov iefremov iefremov approved these changes

Assignees

@spylogsster spylogsster

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

remove Set default search engine screen for BR / AR Update search engine defaults for BR / AR
5 participants
@spylogsster @brave-builds @bsclifton @kjozwiak @iefremov