Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20 Approve amount is rendered incorrectly when MAX_UINT256 #26807

Closed
onyb opened this issue Nov 16, 2022 · 1 comment · Fixed by brave/brave-core#15970
Closed

ERC20 Approve amount is rendered incorrectly when MAX_UINT256 #26807

onyb opened this issue Nov 16, 2022 · 1 comment · Fixed by brave/brave-core#15970
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@onyb
Copy link
Member

onyb commented Nov 16, 2022

In case of Unlimited approvals (MAX_UINT256), we see this in the transaction detail screen:

image

It should instead read "Unlimited ". For any other amount less than MAX_UNINT256, it should rendered as usual.
@onyb onyb added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 16, 2022
@onyb onyb self-assigned this Nov 16, 2022
@onyb onyb added this to Web3 Nov 16, 2022
@onyb onyb mentioned this issue Nov 16, 2022
Merged
25 tasks
@onyb onyb moved this to In Review in Web3 Nov 16, 2022
Repository owner moved this from In Review to Done in Web3 Nov 17, 2022
@onyb onyb added this to the 1.47.x - Nightly milestone Nov 17, 2022
This was referenced Nov 17, 2022
Merged
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.129 Chromium: 108.0.5359.48 (Official Build) (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15970
  • Verified ERC20 Approve amount for unlimited case shows Unlimited instead of long value

image

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): fix ERC20 Approve amount for unlimited case brave/brave-core
3 participants
@onyb @srirambv @brave-builds