Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): fix ERC20 Approve amount for unlimited case (uplift to 1.46.x) #15997

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix(wallet): fix ERC20 Approve amount for unlimited case (uplift to 1.46.x) #15997

merged 1 commit into from
Nov 18, 2022

Conversation

brave-builds
Copy link
Collaborator

Uplift of #15970
Resolves brave/brave-browser#26807

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 17, 2022 16:23
@brave-builds brave-builds self-assigned this Nov 17, 2022
@brave-builds brave-builds added this to the 1.46.x - Beta milestone Nov 17, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 17, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

srirambv
srirambv approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.46.x is approved on behalf of @brave/uplift-approvers . QA has verified the PR on Nightly as per #15970 (comment)

@srirambv srirambv merged commit b0bc71f into 1.46.x Nov 18, 2022
@srirambv srirambv deleted the pr15970_f/wallet/erc20-unlimited_1.46.x branch November 18, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @srirambv @brave-browser-releases