Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix ERC20 Approve amount for unlimited case #15970

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 16, 2022

Resolves brave/brave-browser#26807

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Before After

Steps to reproduce

  1. Create a Swap transaction, where the FROM asset has never been used before for swapping.
  2. This should trigger the "Activate " button. Complete the approval transaction.
  3. Head to transaction history in the panel, and open the detail view for the approval transaction.

@onyb onyb requested a review from a team as a code owner November 16, 2022 13:41
@onyb onyb self-assigned this Nov 16, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 16, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb force-pushed the f/wallet/erc20-unlimited branch from d9274fd to bfca82c Compare November 17, 2022 13:43
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb enabled auto-merge November 17, 2022 15:47
@onyb onyb added this to the 1.47.x - Nightly milestone Nov 17, 2022
@onyb onyb merged commit 7be33a7 into master Nov 17, 2022
@onyb onyb deleted the f/wallet/erc20-unlimited branch November 17, 2022 16:20
brave-builds pushed a commit that referenced this pull request Nov 17, 2022
brave-builds pushed a commit that referenced this pull request Nov 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.84 Chromium: 108.0.5359.48 (Official Build) nightly (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Linux
  • Verified steps from PR
  • Verified ERC20 Approve amount for unlimited case shows Unlimited instead of long value
1.47.75 1.47.84
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC20 Approve amount is rendered incorrectly when MAX_UINT256
4 participants