Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up of #25789 - Choose new server throws Can't connect to server error in both profile 1 and profile 2 #26857

Closed
GeetaSarvadnya opened this issue Nov 18, 2022 · 7 comments · Fixed by brave/brave-core#16065
Closed

Follow up of #25789 - Choose new server throws Can't connect to server error in both profile 1 and profile 2 #26857

GeetaSarvadnya opened this issue Nov 18, 2022 · 7 comments · Fixed by brave/brave-core#16065
Assignees
@simonhong
Labels
bug feature/vpn OS/Desktop OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #25789 - Choose new server throws Can't connect to server error in both profile 1 and profile 2

Steps to Reproduce

  1. Please refer the STR from the issue Choose new server throws Can't connect to server error in both profile 1 and profile 2 #25789 (comment)

Actual result:

Follow up of #25789 - Choose new server throws Can't connect to server error in both profile 1 and profile 2
cannot connect error message

Expected result:

Should not throw any error

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Windows 10 Version 21H2 (Build 19044.2251)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @simonhong @bsclifton
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 18, 2022
Closed
@LaurenWags
Copy link
Member

cc @mattmcalister for visibility

@simonhong simonhong self-assigned this Nov 19, 2022
@simonhong
Copy link
Member

simonhong commented Nov 19, 2022 •
edited
Loading

Checking. It looks like retry once resolves this situation.
Not sure but I suspect that network is temporarily disconnected during the re-connection.
If so, that could cause fetching hostnames for new regions failure. maybe needs one-more retry implicitely.

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 22, 2022
Closed
8 tasks
@simonhong simonhong mentioned this issue Nov 23, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 23, 2022
@simonhong
Improved region change process while connected
b99e198 
fix brave/brave-browser#26857

Network state could be unavailable shortly right after vpn disconnected.
In this case, connect should go ahead if we want to connect after
disconnected. BraveVpnAPIRequest will handle network failure by
retrying.
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 23, 2022
This was referenced Nov 23, 2022
Merged
Merged
@simonhong
Copy link
Member

brave/brave-core#16065 will mitigate this issue but not sure will fix this issue 100%.
@GeetaSarvadnya If you see this again, feel free to open again.

@kjozwiak
Copy link
Member

The above requires 1.46.128 or higher for 1.46.x verification 👍

@stephendonner
Copy link

stephendonner commented Nov 29, 2022 •
edited
Loading

Verified PASSED using

Brave 1.46.129 Chromium: 108.0.5359.48 (Official Build) (x86_64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.129
  2. purchased and configured VPN using issue26857@mailinator.com from account.bravesoftware.com (staging)
  3. connected to BraveVPN, and confirmed VPN is connected to default/nearest server USA (West)
  4. created VPN Profile 2 via the "hamburger" menu
  5. ensured that VPN is connected in profile 2; confirmed VPN is connected to USA (West)
  6. in profile 2, clicked on the VPN button and chose Japan
  7. confirmed Profile 2 connected to Japan without issue
  8. switched to profile 1 and selected USA (North-West)
  9. switched to VPN Profile 2 and confirmed I was connected to USA (North-West)
example example example example example example
Screen Shot 2022-11-28 at 5 00 36 PM Screen Shot 2022-11-28 at 5 01 02 PM Screen Shot 2022-11-28 at 5 01 32 PM Screen Shot 2022-11-28 at 5 01 38 PM Screen Shot 2022-11-28 at 5 01 51 PM Screen Shot 2022-11-28 at 5 02 06 PM

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 29, 2022
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 29, 2022 •
edited
Loading

Verification PASSED on

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
-- | --
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Windows 10 Version 21H2 (Build 19044.2251)
  • Ensured that Can't connect to server error is not shown when user tries to connect new server in Profile 1 an Profile 2
    can't connect error on profile 1 and 2

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 29, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
-- | --
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Steps:

  1. installed 1.46.130
  2. purchased and configured VPN using test4vpn@mailinator.com from account.bravesoftware.com (staging)
  3. connected to BraveVPN, and confirmed VPN is connected to default/nearest server USA (West)
  4. created VPN Profile 2 via the "hamburger" menu
  5. ensured that VPN is connected in profile 2; confirmed VPN is connected to USA (West)
  6. in profile 2, clicked on the VPN button and chose Netherlands
  7. confirmed Profile 2 connected to Netherlands without issue
  8. switched to profile 1 and selected USA (NorthWest)
  9. switched to VPN Profile 2 and confirmed I was connected to USA (NorthWest)

Confirmed Can't connect to server error is not rendered when switching/connecting to new server/regions

step 3 step 5 step 6 step 7 step 9 step 10
image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/vpn OS/Desktop OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Improved region change process while connected brave/brave-core
7 participants
@stephendonner @kjozwiak @simonhong @LaurenWags @GeetaSarvadnya @brave-builds @MadhaviSeelam