Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose new server throws Can't connect to server error in both profile 1 and profile 2 #25789

Closed
GeetaSarvadnya opened this issue Oct 4, 2022 · 4 comments · Fixed by brave/brave-core#15502
Closed

Choose new server throws Can't connect to server error in both profile 1 and profile 2 #25789

GeetaSarvadnya opened this issue Oct 4, 2022 · 4 comments · Fixed by brave/brave-core#15502
Assignees
@simonhong
Labels
feature/vpn OS/Desktop OS/macOS OS/Windows QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
1.46.x - Release

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 4, 2022 •
edited
Loading

Description

Choose other server in Profile 2 throws Can't connect to server error

Steps to Reproduce

Pre-requisites: Enable sku and vpn flags via brave://flags and purchase a vpn

  1. Clean profile 1.45.x
  2. Follow the prerequisites
  3. Enable VPN on profile 1 (Confirmed VPN is cconnected to default/nearest server Singapore)
  4. Create a profile 2 via hamburger menu
  5. Ensure that VPN is connected in profile 2 (Confirmed VPN is connected to Singapore
  6. In profile 2, click on VPN and choose another server
  7. Can't connect to server error is shown
  8. Click on retry connects the server successfully
  9. Go to profile 1 and select the new server
  10. Can't connect to server error is shown
  11. Click on retry connects the server successfully

Actual result:

Choose other server in Profile 2 throws Can't connect to server error

Expected result:

Should not throw any error

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.45.78 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Windows 10 Version 21H2 (Build 19044.2006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @bsclifton @spylogsster @mattmcalister
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 10, 2022 •
edited
Loading

Verified the issue again, the issue happens on the Profile1 also when user tries to connect the new server.

@GeetaSarvadnya GeetaSarvadnya changed the title Choose other server in Profile 2 throws Can't connect to server error Choose other server new server throws Can't connect to server error in both profile 1 and profile 2 Oct 10, 2022
@GeetaSarvadnya GeetaSarvadnya changed the title Choose other server new server throws Can't connect to server error in both profile 1 and profile 2 Choose new server throws Can't connect to server error in both profile 1 and profile 2 Oct 10, 2022
@simonhong simonhong self-assigned this Oct 10, 2022
@simonhong simonhong mentioned this issue Oct 10, 2022
Closed
25 tasks
@bsclifton bsclifton modified the milestone: 1.46.x - Nightly Oct 12, 2022
simonhong added a commit to brave/brave-core that referenced this issue Oct 12, 2022
@simonhong
Fixed region change failure while connected on Windows
0ad1074 
I suspect that this failure comes from vpn disconnect before starting
re-connect to new region. When failure happens, vpn service can't fetch
new credentials from guardian. Maybe disconnect could make network
unavailalbe shortly.

issue: brave/brave-browser#25789
@simonhong simonhong mentioned this issue Oct 18, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Oct 20, 2022
@simonhong
Handled vpn connection state managing in global instance.
8dbfe02 
fix brave/brave-browser#25789

Initially vpn state was per-profile.
However, we decided to share vpn state between all profiles.
With this change, one profile can have same vpn status if other
profile is purchased user.
So far vpn service manages two states.
The one is purchased state and the other is connection state.
Purchased state is still per-profile because skus service is per profile.
Although purchased state is managed by each profile,
same state is shared for all profiles eventually because skus service's
internal data is global.

In this PR connection state managing is moved from per-profile vpn service
to BraveVPNOSConnectionAPI global instance. Before this PR,
BraveVPNOSConnectionAPI didn't have state and only provided abstract interface
for os dependent vpn command such as connect or disconnect.
In the os system, there is only one connection state.
So, connection state also should be managed globally.
With that each profile can see same connection state.
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 20, 2022
This was referenced Oct 20, 2022
Merged
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2022

The above requires 1.46.87 or higher for 1.46.x verification 👍 Believe we might need to wait to verify the above until we can QA the VPN feature with the new SKU SDK. @stephendonner @LaurenWags please correct me if I'm wrong.

@LaurenWags
Copy link
Member

@kjozwiak correct afaik, have added QA/Blocked label until all server side/back end/website work is complete.

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 18, 2022
Closed
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 18, 2022 •
edited
Loading

The issue is still reproducible in the following build hence opened a new follow up issue #26857. Hence marked this issue as QA/No

Brave | 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 10 Version 21H2 (Build 19044.2251)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop OS/macOS OS/Windows QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Move vpn connection state managing to global instance brave/brave-core
6 participants
@kjozwiak @bsclifton @simonhong @LaurenWags @GeetaSarvadnya @brave-builds