Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed region change failure while connected on Windows #15401

Closed

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 10, 2022

I suspect that this failure comes from vpn disconnect before starting re-connect to new region.
When failure happens, vpn service can't fetch new credentials from guardian.
Maybe disconnect could make network unavailalbe shortly.

issue: brave/brave-browser#25789

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests --filter=*VPN*
See the linked issue

@simonhong simonhong self-assigned this Oct 10, 2022
@simonhong simonhong force-pushed the vpn_improve_region_change_while_connected_on_windows branch from ed06668 to cac7828 Compare October 11, 2022 04:44
@bsclifton bsclifton modified the milestone: 1.46.x - Nightly Oct 12, 2022
I suspect that this failure comes from vpn disconnect before starting
re-connect to new region. When failure happens, vpn service can't fetch
new credentials from guardian. Maybe disconnect could make network
unavailalbe shortly.

issue: brave/brave-browser#25789
This reverts commit ada707f16126aebd815f3618d7c04e5f8509ef26.
This reverts commit d04ed456dc53439cedc97976454d5e2a3a672b7e.
Inactive profile should not issue commands implicitely while state is
updating. Active profile will do that.
@simonhong simonhong force-pushed the vpn_improve_region_change_while_connected_on_windows branch from cac7828 to 8b1cff0 Compare October 12, 2022 07:14
@simonhong simonhong marked this pull request as draft October 12, 2022 07:46
@simonhong
Copy link
Member Author

Closed as this PR doesn't fix root cause.

@simonhong simonhong closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants