Selecting "Restore settings to their original defaults" broken

[michaellmonaghan]

Test plan

See https://github.com/brave/brave-core/pull/2130/files

Description

"Restore settings to their original defaults" does nothing. Appears to load indefinitely.

Steps to Reproduce

1. Open settings
2. Click "Restore settings to their original defaults"

Actual result:

Settings not cleared and the following shown indefinitely.

Expected result:

Settings would be cleared.

Reproduces how often:

Reproducible on both machines I use brave on.

Brave version (brave://version info)

0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)]

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  not tested

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  no

• Is the issue reproducible on the latest version of Chrome?
  no

Additional Information

[srirambv]

Issue reproduced on 0.58.18 as well.

[rebron]

cc: @mkarolin can you take a peek when you get a chance?

[LaurenWags]

Issue reproduces with

Brave	0.62.33 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

[jasonrsadler]

When reset pushed, get in console:

[88589:775:0331/105815.341086:ERROR:CONSOLE(123)] 
"Uncaught TypeError: Cannot set property 'checked' of undefined", source: 
chrome://settings/reset_page/reset_profile_dialog.js (123)

[srirambv]

Verification passed on

Brave	0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Linux

• Verified reset settings modal is closed after clicking on reset button
• Verified pinned tabs, search engine and new tab settings are reset
• Logged an issue to reset Brave implementations of shields/social media and extensions settings to be reset Reset browser settings should reset shields/social media/extensions settings #4421

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave	0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Mac OS X

• ensured that the Learn more under the modal opens https://support.brave.com/hc/en-us/articles/360017903152-How-do-I-reset-Brave-settings-to-default-
• ensured that the modal is dismissed when clicking on Cancel
• ensured that the modal is dismissed after clicking on Reset settings
• ensured that bookmarks, history and passwords are not being cleared
• ensured that sessions/cookies are being cleared (made sure I was logged out)
• installed several extensions and ensured they were disabled when clicking on Reset settings (made sure they were appeared disabled under brave://extensions/)
• ensured that search engines, pinned tabs, and on startup are being cleared

Verification passed on

Brave	0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Windows 10 OS Build 17134.523

• Verified reset settings modal is closed after clicking on reset button
• Verified pinned tabs, search engine and new tab settings are reset
• Verified that bookmarks, history and passwords are not being cleared