-
Notifications
You must be signed in to change notification settings - Fork 878
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes brave/brave-browser#2708 Instead of patching the html/js of the reset_profile_dialog, introduced Brave behavior that hides/unchecks/disables the checkbox we don't want seen along with the entire footer of the dialog since it contains nothing else.
- Loading branch information
Showing
7 changed files
with
30 additions
and
39 deletions.
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
browser/resources/settings/brave_reset_page/brave_reset_profile_dialog_behavior.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<script src="brave_reset_profile_dialog_behavior.js"></script> |
23 changes: 23 additions & 0 deletions
23
browser/resources/settings/brave_reset_page/brave_reset_profile_dialog_behavior.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* Copyright (c) 2019 The Brave Authors. All rights reserved. | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
* You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
BraveResetProfileDialogBehavior = { | ||
|
||
ready: function() { | ||
this.fixSendSettingsCheckbox(); | ||
}, | ||
|
||
/** | ||
* Unchecks, disables, and hides sendSettings checkbox. | ||
* Also, hide the entire footer. | ||
* @private | ||
*/ | ||
fixSendSettingsCheckbox: function() { | ||
this.$.sendSettings.checked = false; | ||
this.$.sendSettings.hidden = true; | ||
this.$.sendSettings.disabled = true; | ||
this.$.sendSettings.parentNode.hidden = true; | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
patches/chrome-browser-resources-settings-reset_page-reset_profile_dialog.html.patch
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
patches/chrome-browser-resources-settings-reset_page-reset_profile_dialog.js.patch
This file was deleted.
Oops, something went wrong.