Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OS VPN entry per channel #28028

Closed
simonhong opened this issue Jan 25, 2023 · 4 comments · Fixed by brave/brave-core#16854
Closed

Create OS VPN entry per channel #28028

simonhong opened this issue Jan 25, 2023 · 4 comments · Fixed by brave/brave-core#16854

Comments

@simonhong
Copy link
Member

simonhong commented Jan 25, 2023

Description

Steps to Reproduce

  1. Install two different channels such as nightly and beta
  2. Enable vpn from both releases
  3. Check created os vpn entry

Actual result:

Only BraveVPN entry is created

Expected result:

Different vpn entry should be created for each channels
BraveVPN-Nightly, BraveVPN-Dev, BraveVPN-Beta and BraveVPN

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

@simonhong Windows-only, or should this also apply to macOS?

@simonhong
Copy link
Member Author

@stephendonner I tagged macOS also. Although macOS already have per-channel entry, their name will be changed like BraveVPN-Nightly.

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.88 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.49.88
  2. launched Brave
  3. purchased, configured, and connected to BraveVPN via account.bravesoftware.com
  4. looked at the macOS entries for BraveVPN

Confirmed name is BraveVPN-Beta, which matches my build's channel

browser macOS Network config
Screen Shot 2023-02-07 at 12 22 06 AM Screen Shot 2023-02-07 at 12 22 20 AM

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 10 Version 22H2 (Build 19045.2604)

Steps:

  1. installed 1.49.106
  2. launched Brave
  3. purchased, configured, and connected to BraveVPN via account.bravesoftware.com
  4. looked at the Windows 10 entry for BraveVPN

Confirmed name is BraveVPN-Beta, which matches my build's channel

browser Windows 10 network config
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment