-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OS VPN entry per channel #28028
Labels
Milestone
Comments
@simonhong Windows-only, or should this also apply to |
@stephendonner I tagged macOS also. Although macOS already have per-channel entry, their name will be changed like |
Verified
|
Brave | 1.49.88 Chromium: 110.0.5481.77 (Official Build) beta (x86_64) |
---|---|
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} |
OS | macOS Version 11.7.3 (Build 20G1116) |
Steps:
- installed
1.49.88
- launched Brave
- purchased, configured, and connected to
BraveVPN
viaaccount.bravesoftware.com
- looked at the macOS entries for
BraveVPN
Confirmed name is BraveVPN-Beta
, which matches my build's channel
browser |
macOS Network config |
---|---|
Verified
|
Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit) |
---|---|
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19} |
OS | Windows 10 Version 22H2 (Build 19045.2604) |
Steps:
- installed
1.49.106
- launched Brave
- purchased, configured, and connected to
BraveVPN
viaaccount.bravesoftware.com
- looked at the Windows 10 entry for
BraveVPN
Confirmed name is BraveVPN-Beta
, which matches my build's channel
browser |
Windows 10 network config |
---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Steps to Reproduce
Actual result:
Only
BraveVPN
entry is createdExpected result:
Different vpn entry should be created for each channels
BraveVPN-Nightly
,BraveVPN-Dev
,BraveVPN-Beta
andBraveVPN
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: