Set channel specific vpn entry name #16854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spylogsster
reviewed
Jan 25, 2023
| @@ -432,6 +434,8 @@ BraveBrowserProcessImpl::brave_vpn_os_connection_api() { | |||
|
|
|||
| brave_vpn_os_connection_api_ = brave_vpn::CreateBraveVPNOSConnectionAPI( | |||
| shared_url_loader_factory(), local_state()); | |||
| brave_vpn_os_connection_api_->SetTargetVpnEntryName( | |||
There was a problem hiding this comment.
wdyt about to pass chrome::GetChannel() to CreateBraveVPNOSConnectionAPI to avoid additional calls and simplify interfaces?
spylogsster
reviewed
Jan 25, 2023
| @@ -84,6 +85,22 @@ bool IsBraveVPNEnabled() { | |||
| base::FeatureList::IsEnabled(skus::features::kSkusFeature); | |||
| } | |||
|
|
|||
| std::string GetBraveVPNEntryName(version_info::Channel channel) { | |||
| const std::string entry_name(kBraveVPNEntryName); | |||
There was a problem hiding this comment.
I think we have to make kBraveVPNEntryName internal constant for this function because it can be mistakenly used by anyone from the header. From now on, only this function can be used to determine the name of the connection.
simonhong
force-pushed
the
brave_vpn_entry_name
branch
from
49a2e02
to
5a013f0
Compare
spylogsster
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#28028
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
See the linked issue