Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change delete account error message #28106

Closed
AlexeyBarabash opened this issue Jan 27, 2023 · 4 comments · Fixed by brave/brave-core#17045
Closed

Change delete account error message #28106

AlexeyBarabash opened this issue Jan 27, 2023 · 4 comments · Fixed by brave/brave-core#17045

Comments

@AlexeyBarabash
Copy link
Contributor

Follow-up for brave/brave-core#13562
Found while test #22884 (comment)

Change error text
Could not join this sync chain. Account was deleted. => Could not join this sync chain. The sync chain was deleted.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2023

The above requires 1.49.90 or higher for 1.49.x verification 👍

@stephendonner
Copy link

stephendonner commented Feb 8, 2023

Verified PASSED using the following builds:

macOS:

Brave 1.49.90 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 10 Version 22H2 (Build 19045.2546)

Windows 10:

Brave 1.49.90 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Android:

1.49.90, Chromium 110.0.5481.77 on a Google Pixel XL (arm64) running Android 9

Steps:

  1. installed 1.49.90 on both Android and macOS
  2. launched Brave
  3. created the sync chain on macOS
  4. displayed the QR code and took a screenshot
  5. deleted the sync chain from macOS
  6. on Android, tried to enter the sync chain by scanning the QR code in the screenshot
  7. repeated the above, using Windows 10

Confirmed the error message was Could not join this sync chain. The sync chain was deleted.

Android

example example example example example The sync chain was deleted.
image image (1) image (2) image (3) Screenshot_20230208-123434 Screenshot_20230208-123505

macOS

example example The sync chain was deleted.
Screen Shot 2023-02-08 at 1 08 59 PM Screen Shot 2023-02-08 at 1 09 03 PM Screen Shot 2023-02-08 at 1 09 08 PM

Windows 10

example example The sync chain was deleted.
image image (1) image (2)

@stephendonner
Copy link

Note: I covered macOS, Android, and Windows 10 in the course of testing, but only marked QA Pass-macOS, as we might want to run through at least another desktop test on Windows 10, and on Android, do Android <-> Android etc.

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 version:

Brave	1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit) 
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Android 13; Build/TP1A.220624.014

Test Plan:

Steps:

  1. installed 1.49.118 on both Android
  2. launched Brave
  3. created the sync chain on macOS
  4. displayed the QR code and took a screenshot
  5. deleted the sync chain from macOS
  6. on Android, tried to enter the sync chain by scanning the QR code in the screenshot
  7. Repeated with another Android device
  • Ensured delete sync account copy change
  • Ensured deleting sync chain started on another Android device will still display the error message

Android 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants