-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated error string text for re-joining deleted sync chain case #17045
Conversation
38f1d32
to
9001002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Verification PASSED on
Using the STR/Cases mentioned via #17045 (comment), ensured that the correct text/string is being displayed when attempting to add a Also checked https://github.com/brave/brave-core/pull/17045/files and ensured that the correct string is being displayed. Verification PASSED on
Using the STR/Cases mentioned via #17045 (comment), ensured that the correct text/string is being displayed when attempting to add a
Also checked https://github.com/brave/brave-core/pull/17045/files and ensured that the correct string is being displayed. |
This is just string text change. Agreed with @rmcfadden3 (discussion)
Resolves brave/brave-browser#28106
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please see #13562 (comment) , points C & E, error text should be
Could not join this sync chain. The sync chain was deleted.