Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated error string text for re-joining deleted sync chain case #17045

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Feb 5, 2023

This is just string text change. Agreed with @rmcfadden3 (discussion)

Resolves brave/brave-browser#28106

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please see #13562 (comment) , points C & E, error text should be Could not join this sync chain. The sync chain was deleted.

@AlexeyBarabash AlexeyBarabash changed the title Updated error string text for re-joining deleted sync chain case; fix… Updated error string text for re-joining deleted sync chain case Feb 5, 2023
@AlexeyBarabash AlexeyBarabash added feature/sync CI/skip-ios Do not run CI builds for iOS labels Feb 5, 2023
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review February 5, 2023 21:21
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.14 Chromium: 110.0.5481.77 (Official Build) nightly (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 22H2 (Build 22621.1194)

Using the STR/Cases mentioned via #17045 (comment), ensured that the correct text/string is being displayed when attempting to add a sync chain that was removed/deleted by the user. Example of the new string:

syncRemovalDesktop

Also checked https://github.com/brave/brave-core/pull/17045/files and ensured that the correct string is being displayed.


Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.14 Chromium: 110.0.5481.77 (Official Build) canary (32-bit)
--- | ---
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Android 13; Build/TQ1A.230105.002

Using the STR/Cases mentioned via #17045 (comment), ensured that the correct text/string is being displayed when attempting to add a sync chain that was removed/deleted by the user. Example of the new string:

Example Example
Screenshot_20230206-234350 Screenshot_20230206-234737

Also checked https://github.com/brave/brave-core/pull/17045/files and ensured that the correct string is being displayed.

kjozwiak pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS feature/sync
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Change delete account error message
4 participants