Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding in Japan region shows auto contribution slide #28221

Closed
LaurenWags opened this issue Feb 1, 2023 · 4 comments · Fixed by brave/brave-core#17021
Closed

onboarding in Japan region shows auto contribution slide #28221

LaurenWags opened this issue Feb 1, 2023 · 4 comments · Fixed by brave/brave-core#17021
Assignees
Labels
feature/rewards japan OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@LaurenWags
Copy link
Member

Description

When you select "Japan" as the country for Rewards, there should not be a slide in onboarding that describes Auto Contribution.

This works as expected on desktop.

Steps to reproduce

  1. Have device set to US (or non Japan region)
  2. Install 1.48.x
  3. Select Japan as the country
  4. Go through onboarding

Actual result

below slide should not be part of onboarding:

Screenshot_20230201-164420

Expected result

No AC slide in onboarding

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? likely

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.48.152

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @Miyayes @deeppandya @brave/qa-team

@LaurenWags LaurenWags added feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 1, 2023
@Miyayes Miyayes added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Feb 2, 2023
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Feb 2, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 2, 2023

Applies to new users whose Android device locale == not-JP, but then declares Japan.

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 8, 2023

Target 1.48.x maintenance release

@kjozwiak
Copy link
Member

The above requires 1.48.161 or higher for 1.48.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 using version:

Brave	1.48.166 Chromium: 110.0.5481.100 (Official Build) (64-bit) 
Revision	4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS	Android 13; Build/TP1A.220624.014

STR: #28221 (comment)

  • Ensured that auto contribution slide is not displayed in the quick tour upon joining rewards for Japan
Example Example Example
screenshot-1676650490264 screenshot-1676650498353 screenshot-1676650654650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards japan OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants