-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rewards onboarding check for JP #17021
Conversation
@@ -214,7 +214,7 @@ | |||
|
|||
<color name="rewards_panel_bg_color">#FAFCFF</color> | |||
<color name="rewards_panel_text_color">#212529</color> | |||
<color name="rewards_panel_secondary_text_color">#868E96</color> | |||
<color name="rewards_panel_secondary_text_color">#495057</color> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This color is used in many places. Like in tipping panel. May be better to create new color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verified on Google Pixel 3 XL with Android 12 running 1.50.21.
Case 1:
Case 2:
|
Uplift of #17021 (squashed) to beta
Uplift of #17021 (squashed) to release
Resolves brave/brave-browser#28221
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: