Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewards onboarding check for JP #17021

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#28221

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 3, 2023
@deeppandya deeppandya added this to the 1.50.x - Nightly milestone Feb 3, 2023
@deeppandya deeppandya self-assigned this Feb 3, 2023
@@ -214,7 +214,7 @@

<color name="rewards_panel_bg_color">#FAFCFF</color>
<color name="rewards_panel_text_color">#212529</color>
<color name="rewards_panel_secondary_text_color">#868E96</color>
<color name="rewards_panel_secondary_text_color">#495057</color>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color is used in many places. Like in tipping panel. May be better to create new color.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 5c2cb7f into master Feb 4, 2023
@deeppandya deeppandya deleted the update_rewards_check_for_jp branch February 4, 2023 15:47
brave-builds added a commit that referenced this pull request Feb 4, 2023
brave-builds added a commit that referenced this pull request Feb 4, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Feb 8, 2023

Verified on Google Pixel 3 XL with Android 12 running 1.50.21.

Case 1:

  • Device is set to US
  • Selected Japan as country
  • Confirmed no "Auto Contribution" slide in onboarding
  • Confirmed bitFlyer is the only custodian option
Device Geo Selection Onboarding Onboarding Onboarding Onboarding Onboarding brave://rewards page Custodian
1 2 3 4 5 6 7 8 9

Case 2:

  • Device is set to Japan
  • Selected Japan as country
  • Confirmed no "Auto Contribution" slide in onboarding
  • Confirmed bitFlyer is the only custodian option
Device Geo Selection Onboarding Onboarding Onboarding Onboarding Onboarding brave://rewards page Custodian
1 2 3 4 5 6 7 8 9

kjozwiak pushed a commit that referenced this pull request Feb 10, 2023
kjozwiak pushed a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onboarding in Japan region shows auto contribution slide
4 participants