Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards Site Banner Busted 😱 #2984

Closed
jhreis opened this issue Jan 16, 2019 · 0 comments · Fixed by brave/brave-core#1391
Closed

Brave Rewards Site Banner Busted 😱 #2984

jhreis opened this issue Jan 16, 2019 · 0 comments · Fixed by brave/brave-core#1391

Comments

@jhreis
Copy link

jhreis commented Jan 16, 2019

Description

"Send a Tip" opens the tipping box, however it is completely white, and stuck. I am unable to dismiss it and even persists between page refreshes. Must close tab.

Steps to Reproduce

  1. Visit a website (AFAIK doesn't matter which one) (e.g. github.com, twitter.com)
  2. Click the Brave rewards icon
  3. Click "Send a Tip"
  4. Observe stuck white banner

Console gives following error:

brave_donate.bundle.js:22 Uncaught TypeError: Cannot read property ‘toString’ of undefined
at Object.render (brave_donate.bundle.js:381)
at Ta (brave_donate.bundle.js:22)
at Oa (brave_donate.bundle.js:22)
at di (brave_donate.bundle.js:22)
at Ai (brave_donate.bundle.js:22)
at Gi (brave_donate.bundle.js:22)
at Zi (brave_donate.bundle.js:22)
at zi (brave_donate.bundle.js:22)
at Qi (brave_donate.bundle.js:22)
at yi (brave_donate.bundle.js:22)

Actual result:

Stuck white banner appears.

Expected result:

Actual tip banner that is dismiss-able.

Reproduces how often:

100%

Brave version (brave://version info)

  • Brave | 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
  • Revision | 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{Support nightly channel on linux #461}
  • OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Brave Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Screenshots

Stuck Banner
Console Error
Console Error Pretty-ified

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 16, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 16, 2019
@NejcZdovc NejcZdovc changed the title Brave Rewards "Send a Tip" Panel Busted 😱 Brave Rewards Site Banner Busted 😱 Jan 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 18, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants