Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset skus from brave://skus-internals #30191

Closed
Tracked by #26788
simonhong opened this issue May 8, 2023 · 3 comments · Fixed by brave/brave-core#18403
Closed
Tracked by #26788

Reset skus from brave://skus-internals #30191

simonhong opened this issue May 8, 2023 · 3 comments · Fixed by brave/brave-core#18403

Comments

@simonhong
Copy link
Member

Add reset button brave://skus-internals and reset skus state from local state

When reset button is pressed, skus.state should be reverted to default.

@simonhong simonhong self-assigned this May 8, 2023
simonhong added a commit to brave/brave-core that referenced this issue May 8, 2023
@simonhong simonhong added QA/Yes and removed QA/No labels May 9, 2023
simonhong added a commit to brave/brave-core that referenced this issue May 13, 2023
fix brave/brave-browser#30191

react-json-view-lite is used to render skus state in json tree view.
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 16, 2023
@stephendonner
Copy link

stephendonner commented May 18, 2023

Verification PASSED using

Brave 1.53.50 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 13.4 (Build 22F66)

Steps:

  1. installed 1.53.50
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com (staging)
  4. opened brave://skus-internals
  5. clicked on Fetch SKUs state
  6. confirmed JSON nested-tree blob
  7. disconnected from Brave VPN
  8. clicked on Reset SKUs state
  9. confirmed was prompted to confirm, with warning
  10. clicked OK
  11. confirmed JSON view was cleared of its values (but still had its top-level fields)
  12. waited some time for VPN-session credentials to time out/expire
  13. clicked on the VPN button in the toolbar

Confirmed my credentials were wiped, and I was presented with the Buy/Already purchased VPN? dialog

example example example example example example
Screenshot 2023-05-18 at 10 15 33 AM Screenshot 2023-05-18 at 10 17 53 AM Screenshot 2023-05-18 at 10 18 18 AM Screenshot 2023-05-18 at 10 18 51 AM Screenshot 2023-05-18 at 10 18 57 AM Screenshot 2023-05-18 at 10 19 27 AM

@kjozwiak
Copy link
Member

The above needs to be re-verified due to brave/brave-core#18356, brave/brave-core#18403 & brave/brave-core#18527 being uplifted into 1.52.x via brave/brave-core#18538. Used #30191 (comment) as the needed verification on Nightly to uplift into 1.52.x as per brave/brave-core#18538 (review).

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 25, 2023
@stephendonner
Copy link

stephendonner commented May 25, 2023

Verification PASSED using

Brave 1.52.112 Chromium: 114.0.5735.35 (Official Build) (x86_64)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS macOS Version 13.5 (Build 22G5027e)

Steps:

  1. installed 1.52.112
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com (staging)
  4. opened brave://skus-internals
  5. clicked on Fetch SKUs state
  6. confirmed JSON nested-tree blob
  7. disconnected from Brave VPN
  8. clicked on Reset SKUs state
  9. confirmed was prompted to confirm, with warning
  10. clicked OK
  11. confirmed JSON view was cleared of its values (but still had its top-level fields)
  12. waited some time for VPN-session credentials to time out/expire
  13. clicked on the VPN button in the toolbar

Confirmed my credentials were wiped, and I was presented with the Buy/Already purchased VPN? dialog

example example example example example example
Screenshot 2023-05-25 at 11 02 36 AM Screenshot 2023-05-25 at 11 02 56 AM Screenshot 2023-05-25 at 11 03 19 AM Screenshot 2023-05-25 at 11 03 33 AM Screenshot 2023-05-25 at 11 03 37 AM Screenshot 2023-05-25 at 11 03 45 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment