-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset skus from brave://skus-internals #30191
Milestone
Comments
3 tasks
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
May 8, 2023
simonhong
added a commit
to brave/brave-core
that referenced
this issue
May 13, 2023
fix brave/brave-browser#30191 react-json-view-lite is used to render skus state in json tree view.
Verification
|
Brave | 1.53.50 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64) |
---|---|
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454} |
OS | macOS Version 13.4 (Build 22F66) |
Steps:
- installed
1.53.50
- launched Brave
- purchased, configured, and connected to
Brave VPN
usingaccount.bravesoftware.com
(staging) - opened
brave://skus-internals
- clicked on
Fetch SKUs state
- confirmed JSON nested-tree blob
- disconnected from
Brave VPN
- clicked on
Reset SKUs state
- confirmed was prompted to confirm, with warning
- clicked
OK
- confirmed JSON view was cleared of its values (but still had its top-level fields)
- waited some time for VPN-session credentials to time out/expire
- clicked on the
VPN
button in the toolbar
Confirmed my credentials were wiped, and I was presented with the Buy
/Already purchased VPN?
dialog
example | example | example | example | example | example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
7 tasks
The above needs to be re-verified due to brave/brave-core#18356, brave/brave-core#18403 & brave/brave-core#18527 being uplifted into |
Verification
|
Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (x86_64) |
---|---|
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713} |
OS | macOS Version 13.5 (Build 22G5027e) |
Steps:
- installed
1.52.112
- launched Brave
- purchased, configured, and connected to
Brave VPN
usingaccount.bravesoftware.com
(staging) - opened
brave://skus-internals
- clicked on
Fetch SKUs state
- confirmed JSON nested-tree blob
- disconnected from
Brave VPN
- clicked on
Reset SKUs state
- confirmed was prompted to confirm, with warning
- clicked
OK
- confirmed JSON view was cleared of its values (but still had its top-level fields)
- waited some time for VPN-session credentials to time out/expire
- clicked on the
VPN
button in the toolbar
Confirmed my credentials were wiped, and I was presented with the Buy
/Already purchased VPN?
dialog
example | example | example | example | example | example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add reset button brave://skus-internals and reset skus state from local state
When reset button is pressed,
skus.state
should be reverted to default.The text was updated successfully, but these errors were encountered: