Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://skus-internals stub code #18356

Merged
merged 1 commit into from
May 5, 2023
Merged

brave://skus-internals stub code #18356

merged 1 commit into from
May 5, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 4, 2023 •
edited
Loading

fix brave/brave-browser#30153

brave://skus-internals page will show skus service's event logs.
This PR just makes brave://skus-internal loadable.
Gathering & showing logs will be done as a next step.

image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave and load brave://skus-internals
  2. Check page is loaded. (contents is not ready)

@simonhong simonhong requested a review from bsclifton May 4, 2023 04:51
@simonhong simonhong self-assigned this May 4, 2023
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels May 4, 2023
@simonhong simonhong force-pushed the skus_internals_stub_code branch 3 times, most recently from 62c25b4 to d8d1df1 Compare May 4, 2023 04:55
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong simonhong marked this pull request as ready for review May 4, 2023 07:05
@simonhong simonhong requested a review from a team as a code owner May 4, 2023 07:05
@simonhong simonhong force-pushed the skus_internals_stub_code branch from d8d1df1 to bb329ed Compare May 4, 2023 11:15
@simonhong simonhong requested a review from a team as a code owner May 4, 2023 11:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

mkarolin
mkarolin approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong
brave://skus-internals stub code
bd99ee6 
fix brave/brave-browser#30153

brave://skus-internals page will show skus service's event logs.
This PR just makes brave://skus-internal loadable.
Gathering & showing logs will be done as a next step.
@simonhong simonhong force-pushed the skus_internals_stub_code branch from bb329ed to bd99ee6 Compare May 5, 2023 00:12
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong simonhong merged commit 9832541 into master May 5, 2023
@simonhong simonhong deleted the skus_internals_stub_code branch May 5, 2023 09:48
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 5, 2023
@bsclifton bsclifton mentioned this pull request May 18, 2023
Merged
7 tasks
bsclifton pushed a commit that referenced this pull request May 22, 2023
@simonhong @bsclifton
Merge pull request #18356 from brave/skus_internals_stub_code
a865fe0 
brave://skus-internals stub code
kjozwiak pushed a commit that referenced this pull request May 23, 2023
@bsclifton @simonhong
brave://skus-internals rev1 implementation (uplift to 1.52.x) (#18538)
8c7b389 
* Merge pull request #18356 from brave/skus_internals_stub_code

brave://skus-internals stub code

* Merge pull request #18403 from brave/reset_skus_state_from_webui

Reset skus state from webui

* Merge pull request #18527 from brave/fix_skus_internals_webui_crash

Fixed crash when loading skus_internals webui

* lint fixes

---------

Co-authored-by: Simon Hong <shong@brave.com>
@kjozwiak kjozwiak mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@simonhong simonhong

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.

Implement stub brave://skus-internals page
3 participants
@simonhong @brave-builds @mkarolin