Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component updater should check for Brave Ad Block Resources Library updates more often #32274

Closed
bsclifton opened this issue Aug 15, 2023 · 5 comments · Fixed by brave/brave-core#20557

Comments

@bsclifton
Copy link
Member

Description

Component updater by default checks for an update:

  • Within a minute of launch
  • Within 15 mins of launch
  • Every 5 hours after that

That frequency can be seen here:
https://source.chromium.org/chromium/chromium/src/+/main:components/component_updater/configurator_impl.cc;l=53-81;drc=8c7b66805bf4b91c4ed772bb62fe9b0a7e2e427a

We need to check more often for the Brave Ad Block Resources Library component, because there could be adblock definition updates. Maybe we can check every 30 minutes or every hour. Exact frequency needs to be determined

cc: @mschfh @pes10k

We can likely accomplish this the same way we check for sponsored image updates. Here's an example of that:
https://github.com/brave/brave-core/blob/e9f0de92096c80e74de5a7731590ec93ab08890e/components/ntp_background_images/browser/ntp_background_images_service.cc#L188-L198

@bsclifton bsclifton added feature/shields/adblock Blocking ads & trackers with Shields feature/components OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 15, 2023
@bsclifton bsclifton self-assigned this Aug 15, 2023
@bsclifton
Copy link
Member Author

tentatively assigning myself until we can find a resource to help

@antonok-edm antonok-edm self-assigned this Sep 13, 2023
@bsclifton bsclifton removed their assignment Sep 14, 2023
@bsclifton bsclifton self-assigned this Oct 11, 2023
@bsclifton
Copy link
Member Author

We'll likely want to do this for a few others (need to verify):

  • Ad Block Updater
  • Ad Block First Party

@kjozwiak
Copy link
Member

The above requires 1.59.124 or higher for 1.59.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.59.124 Chromium: 118.0.5993.117 (Official Build) (64-bit)
--- | ---
Revision | 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS | Android 14; Build/U1B2.230922.010; 34; REL
  • launched 1.59.124 Chromium: 118.0.5993.117 and ensured that AdBlockComponentUpdateIntervalStudy:Enabled via brave://version
  • ensured that Brave Ad Block First Party Filters, Brave Ad Block Updater, Brave Ad Block Resources Library were being updated every ~1min
    • open brave://components and refresh the page
    • all of the components should be appearing as Up-to-date
    • wait ~1min and you'll notice that Brave Ad Block First Party Filters, Brave Ad Block Updater, Brave Ad Block Resources Library will appear as Status - Component already up to date.
Example Example
Screenshot_20231025-114905 Screenshot_20231025-115157

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.59.124 Chromium: 118.0.5993.117 (Official Build) (64-bit)
-- | --
Revision | 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS | Windows 11 Version 22H2 (Build 22621.2428)

Using the STR/Cases outlined via brave/brave-core#20557 (comment), ensured the following:

  • launched 1.61.45 Chromium: 118.0.5993.96 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and restarted the browser
  • ensured that AdBlockComponentUpdateIntervalStudy:Enabled via brave://version
  • ensured that Brave Ad Block First Party Filters, Brave Ad Block Updater, Brave Ad Block Resources Library were being updated every ~1min
    • open brave://components and refresh the page
    • all of the components should be appearing as Up-to-date
    • wait ~1min and you'll notice that Brave Ad Block First Party Filters, Brave Ad Block Updater, Brave Ad Block Resources Library will appear as Status - Component already up to date.
Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants