-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component updater should check for Brave Ad Block Resources Library
updates more often
#32274
Labels
feature/components
feature/shields/adblock
Blocking ads & trackers with Shields
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
bsclifton
added
feature/shields/adblock
Blocking ads & trackers with Shields
feature/components
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Aug 15, 2023
tentatively assigning myself until we can find a resource to help |
We'll likely want to do this for a few others (need to verify):
|
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Oct 17, 2023
This was referenced Oct 18, 2023
Merged
brave-builds
modified the milestones:
1.61.x - Nightly,
1.60.x - Beta,
1.59.x - Release #4
Oct 24, 2023
The above requires |
Verification PASSED on
Using the STR/Cases outlined via brave/brave-core#20557 (comment), ensured the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/components
feature/shields/adblock
Blocking ads & trackers with Shields
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/include
Description
Component updater by default checks for an update:
That frequency can be seen here:
https://source.chromium.org/chromium/chromium/src/+/main:components/component_updater/configurator_impl.cc;l=53-81;drc=8c7b66805bf4b91c4ed772bb62fe9b0a7e2e427a
We need to check more often for the
Brave Ad Block Resources Library
component, because there could be adblock definition updates. Maybe we can check every 30 minutes or every hour. Exact frequency needs to be determinedcc: @mschfh @pes10k
We can likely accomplish this the same way we check for sponsored image updates. Here's an example of that:
https://github.com/brave/brave-core/blob/e9f0de92096c80e74de5a7731590ec93ab08890e/components/ntp_background_images/browser/ntp_background_images_service.cc#L188-L198
The text was updated successfully, but these errors were encountered: