Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted some adblock components update check interval (uplift to 1.59.x) #20592

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Adjusted some adblock components update check interval (uplift to 1.59.x) #20592

merged 2 commits into from
Oct 24, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 18, 2023 •
edited by kjozwiak
Loading

Uplift of #20137
Uplift of #20557
Resolves brave/brave-browser#32799
Resolves brave/brave-browser#32274

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 18, 2023 20:38
@brave-builds brave-builds self-assigned this Oct 18, 2023
@brave-builds brave-builds added this to the 1.59.x - Release #3 milestone Oct 18, 2023
@bsclifton bsclifton force-pushed the pr20557_adjust_adblock_resource_component_update_interval_1.59.x branch from b2e3248 to 69d89a2 Compare October 20, 2023 23:51
@bsclifton bsclifton force-pushed the pr20557_adjust_adblock_resource_component_update_interval_1.59.x branch from 69d89a2 to bc0fd8f Compare October 21, 2023 08:00
kjozwiak
kjozwiak approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.59.x approved 👍 QA has verified the PR(s) on Nightly via #20137 (comment) & #20557 (comment).

@kjozwiak kjozwiak merged commit 4781378 into 1.59.x Oct 24, 2023
3 checks passed
@kjozwiak kjozwiak deleted the pr20557_adjust_adblock_resource_component_update_interval_1.59.x branch October 24, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.59.x - Release #4
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @cuba