Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Use correct components for Adblock services #32799

Closed
cuba opened this issue Sep 6, 2023 · 8 comments · Fixed by brave/brave-core#20137
Closed

[iOS] Use correct components for Adblock services #32799

cuba opened this issue Sep 6, 2023 · 8 comments · Fixed by brave/brave-core#20137

Comments

@cuba
Copy link

cuba commented Sep 6, 2023

We use legacy components for Adblock services to fetch things like the default and custom filter lists. We need to use the correct components

  • Use the unified list_catalog.json file for getting the correct default/custom component details
  • see what we can re-use (maybe move) on desktop to use as many shared files as possible (if anything)

Test strategy

  1. Just need to test some general ad-blocking and filter lists functionality on desktop
@cuba cuba added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 6, 2023
@antonok-edm
Copy link
Collaborator

antonok-edm commented Sep 6, 2023

For reference: https://github.com/brave/brave-browser/wiki/Brave-Components

Can be migrated independently

  • Brave Ad Block List Catalog (for regional_lists.json)
  • Brave Ad Block Resources Library (for resources.json)

Depends on all of the above

  • Brave Ad Block Updater
  • Regional lists

Last step

requires brave/brave-core#19946

Migrate regional_lists.json to list_catalog.json (contained in the same component).

@kjozwiak
Copy link
Member

The above requires 1.59.124 or higher for 1.59.x verification 👍

@kjozwiak
Copy link
Member

The above can also be verified alongside #33718. Basically ensuring that adblocking is working as expected.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 25, 2023

Verification PASSED on

Brave | 1.59.124 Chromium: 118.0.5993.117 (Official Build) (64-bit)
-- | --
Revision | 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS | Windows 10 Version 22H2 (Build 19045.3570)

Using the STR/information outlined via #32799 (comment), ensured that ad-blocking was generally working as per the following:

Quick Note: If this regressed general blocking, we would have heard it by now from Nighty users within Brave.

  • visited https://www.zerohedge.com and disabled shields and ensured that ads loaded within the page
    • re-enabled shields and ensured that ads were being blocked without issues
  • visited https://www.google.ca and searched for Under Armour and ensured that first-party ads were appearing
    • switched to Aggressively block tracker & ads and ensured those ads were being removed/not being displayed anymore
  • visited https://www.blizzard.com/en-gb/ and ensured that enabling Block scripts blocked the carousel
  • visited https://digikey.com and ensured there was no cookie consent banner being displayed at the top of the page
    • image
  • visited https://mixed-script.badssl.com and ensured the page appears grey

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 25, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.59.124

  • visited https://www.zerohedge.com and disabled shields and ensured that ads loaded within the page
    • re-enabled shields and ensured that ads were being blocked without issues
  • visited https://www.google.ca and searched for Under Armour and ensured that first-party ads were appearing
    • switched to Aggressively block tracker & ads and ensured those ads were being removed/not being displayed anymore
  • visited https://www.blizzard.com/en-gb/ and ensured that enabling Block scripts blocked the carousel
  • visited https://digikey.com and ensured there was no cookie consent banner being displayed at the bottom of the page
    • Screenshot_20231025_220535
  • visited https://mixed-script.badssl.com and ensured the page appears grey

@hffvld
Copy link
Contributor

hffvld commented Oct 25, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.59.124
Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision: 63d57e32ce0ff0a1e380461bc394351e97d1416a

STEPS:

  1. Followed the steps from [iOS] Use correct components for Adblock services #32799 (comment)

ACTUAL RESULTS:

  • Verified that ads loaded within the page when visited https://www.zerohedge.com/ and disabled Shields. Re-enabled Shields and verified that ads were being blocked without issues.
  • Verified that first-party ads were appearing when visited https://www.google.com/ and searched for Under Armour. Switched to Aggressively block tracker & ads and verified those ads were being removed/not being displayed anymore
  • Verified that enabling Block scripts blocked the carousel when visiting https://www.blizzard.com.
  • Verified that there was no cookie consent banner being displayed on the page when visiting https://digikey.com if Block cookie consent notices toggle is ON.
  • Verified that the page appears grey when visiting https://mixed-script.badssl.com

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@btlechowski
Copy link

Verified with

Brave 1.59.124 Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS Linux

Using the STR/information outlined via #32799 (comment), ensured that ad-blocking was generally working as per the following:

  • visited https://www.zerohedge.com and disabled shields and ensured that ads loaded within the page
    • re-enabled shields and ensured that ads were being blocked without issues
image image
  • visited https://www.google.ca and searched for Under Armour and ensured that first-party ads were appearing

    • switched to Aggressively block tracker & ads and ensured those ads were being removed/not being displayed anymore
  • visited https://www.blizzard.com/en-gb/ and ensured that enabling Block scripts blocked the carousel
    image

  • visited https://digikey.com and ensured there was no cookie consent banner being displayed at the top of the page

  • visited https://mixed-script.badssl.com and ensured the page appears grey

  • verified filter lists work:

image image image

@kjozwiak
Copy link
Member

Verification PASSED on macOS 14.0 x64 Sonoma using the following build(s):

Brave | 1.59.124 Chromium: 118.0.5993.117 (Official Build) (x86_64)
--- | ---
Revision | 63d57e32ce0ff0a1e380461bc394351e97d1416a
OS | macOS Version 14.0 (Build 23A344)

Using the STR/information outlined via #32799 (comment), ensured that ad-blocking was generally working as per the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants