-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Merge all filter lists (including general ones) into one engine #36035
Comments
Copying the text from brave/brave-ios#6624, for reference:
|
Adding missing milestone labels as brave/brave-core#22127 (comment) was formatted incorrectly so the automation didn't move the issue into the correct milestone. |
Verified on Using Test Plan in PR brave/brave-core#22127 (comment):
|
Should be tested on iPad as well. Added |
Description:
The filter lists work better when they are merged into a single engine since some filter lists are designed to work with parent filter lists.
EDIT: This is not fully possible. However we can probably still achieve a part of this by doing the following
This requires the following Issues to be completed first:
Note: The network blocking will still not be combined if we do this. But we should get better results for cosmetic filter, script injection and some async network blocking rules. This will also allow us to add custom lists exceptions to test CF and scripts.
Additional Information
For this we need the raw text versions of the files to be exposed. This is done here: brave/brave-core-crx-packager#468
The text was updated successfully, but these errors were encountered: