Ship default adblock lists in plaintext format #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
reviewed
Aug 31, 2022
| @@ -34,6 +34,9 @@ const generateManifestFile = async (name, base64PublicKey, uuid) => { | |||
| const generateManifestFileForDefaultAdblock = | |||
| generateManifestFile.bind(null, 'Default', defaultAdblockBase64PublicKey, 'default') // eslint-disable-line | |||
|
|
|||
| const generateManifestFileForDefaultPlaintextAdblock = | |||
| generateManifestFile.bind(null, 'Default (plaintext)', defaultPlaintextPubkey, defaultPlaintextComponentId) // eslint-disable-line | |||
There was a problem hiding this comment.
This is not really related to this PR, but what's the es-lint rule that fails here? Maybe we should disable it globally instead of ignoring any warnings/errors on all of these lines?
There was a problem hiding this comment.
Hmm, good call. npm run lint actually uses standard, there's no eslint at all here. I can remove those comments.
fmarier
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated a new component ID and pubkey for the plaintext format of our default adblock lists; the corresponding PEM has been uploaded to 1Password and is updated in Jenkins as well. This PR uses them to generate a new plaintext component version of the default lists.