Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with public keys when redeeming tokens #3655

Closed
tmancey opened this issue Mar 11, 2019 · 1 comment · Fixed by brave/brave-core#1907
Closed

Fix issue with public keys when redeeming tokens #3655

tmancey opened this issue Mar 11, 2019 · 1 comment · Fixed by brave/brave-core#1907

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 11, 2019

Description

Fix issue with public keys when redeeming tokens as we are incorrectly sending the wallet public key instead of the issuers public key

Test Plan / Steps to Reproduce

  1. View an Ad
  2. Close browser
  3. Relaunch browser
  4. Confirm on Ads Serve that token was cashed out (additional steps are required on Ads Serve, please check with @maikelmclauflin and Jimmy)

Actual result:

Server fails to cash out token due to incorrect public key

Expected result:

Server cashes out token

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Dev and Nightly

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

Speak to @amirsaber for help with testing server side

@btlechowski
Copy link

btlechowski commented Apr 18, 2019

Verification passed by Geeta on

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Verified passed with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux
  • Verified tokens redeemed with help from @jsecretan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment