Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto contribution table often contains 2^32 - 1(4294967295) percentage entry for a short period of time #3668

Closed
darkdh opened this issue Mar 11, 2019 · 2 comments · Fixed by brave/brave-core#2187

Comments

@darkdh
Copy link
Member

darkdh commented Mar 11, 2019

Description

image

image

There entries all have -1 percent in activity_info in publisher_info_db like
bcbsm.com|16|1|1.05088239607526|-1|0.49724982169539|1553877406

Steps to Reproduce

  1. Have a auto contribution table
  2. Start excluding some entries
  3. 4294967295% entry will appear
  4. Keep removing, there will be more 4294967295 coming

Actual result:

Expected result:

Reproduces how often:

very often

Brave version (brave://version info)

0.63,4

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 18, 2019
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc Apr 4, 2019
@jasonrsadler
Copy link

jasonrsadler commented Apr 8, 2019

Repro'd underflow. Working.
Screen Shot 2019-04-08 at 4 21 35 PM

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 12, 2019
Address PR comments
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 13, 2019
Address PR comments
@jasonrsadler jasonrsadler added this to the 0.65.x - Nightly milestone Apr 15, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 3, 2019

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants