-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Contribute list percentages now do not underflow #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
requested review from
bridiver,
ryanml,
NejcZdovc and
SergeyZhukovsky
April 9, 2019 21:53
jasonrsadler
changed the title
Fixes brave/brave-browser#3668
Auto-Contribute list percentages now do not underflow
Apr 9, 2019
NejcZdovc
reviewed
Apr 10, 2019
vendor/bat-native-ledger/src/bat/ledger/internal/bat_publishers_unittest.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Apr 10, 2019
vendor/bat-native-ledger/src/bat/ledger/internal/bat_publishers.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Apr 10, 2019
vendor/bat-native-ledger/src/bat/ledger/internal/bat_publishers.cc
Outdated
Show resolved
Hide resolved
jasonrsadler
force-pushed
the
normalize-pct-correction
branch
from
April 10, 2019 10:38
7f98b3d
to
1cbc005
Compare
jasonrsadler
force-pushed
the
normalize-pct-correction
branch
from
April 11, 2019 00:41
b5b9388
to
5fec1fb
Compare
NejcZdovc
force-pushed
the
normalize-pct-correction
branch
from
April 11, 2019 05:15
8ca53cc
to
93f623b
Compare
jasonrsadler
force-pushed
the
normalize-pct-correction
branch
from
April 11, 2019 13:36
93f623b
to
09eff48
Compare
jasonrsadler
force-pushed
the
normalize-pct-correction
branch
2 times, most recently
from
April 12, 2019 17:34
8e0ceae
to
4f70734
Compare
Address PR comments
jasonrsadler
force-pushed
the
normalize-pct-correction
branch
from
April 13, 2019 10:07
4f70734
to
3197abf
Compare
NejcZdovc
approved these changes
Apr 15, 2019
jasonrsadler
pushed a commit
that referenced
this pull request
Apr 16, 2019
Auto-Contribute list percentages now do not underflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3668
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: