Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Contribute list percentages now do not underflow #2187

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Apr 9, 2019

Fixes brave/brave-browser#3668

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave clean profile, enable rewards.
  2. Add a lot of sites to auto-contribute
  3. Go to Rewards page and start excluding sites.
  4. Make sure highest percentage does not go above 100%

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler added this to the 0.65.x - Nightly milestone Apr 9, 2019
@jasonrsadler jasonrsadler self-assigned this Apr 9, 2019
@jasonrsadler jasonrsadler changed the title Fixes brave/brave-browser#3668 Auto-Contribute list percentages now do not underflow Apr 9, 2019
Address PR comments
@jasonrsadler jasonrsadler merged commit 959e3c4 into master Apr 15, 2019
@jasonrsadler jasonrsadler deleted the normalize-pct-correction branch April 15, 2019 10:04
jasonrsadler pushed a commit that referenced this pull request Apr 16, 2019
Auto-Contribute list percentages now do not underflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto contribution table often contains 2^32 - 1(4294967295) percentage entry for a short period of time
2 participants