Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #36723] Shape answers based on the page's contents doesn't fit the screen in Portrait Mode #36856

Closed
hffvld opened this issue Mar 15, 2024 · 3 comments · Fixed by brave/brave-core#22627
Labels
browser-ai bug OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release/blocking release-notes/exclude

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 15, 2024

Description:

Follow-up to #36723

Steps to Reproduce

  1. Switch device to Non-English language
  2. Launch Brave
  3. Open any website
  4. Open Leo > Observe

Actual result:

The string Shape answers based on the page's contents doesn't fit the screen in Portrait Mode in most languages like Russian, Spanish, French, German, etc. This is not the issue on iPad.

Russian Spanish French German
1 2 3 4

Expected result:

The string Shape answers based on the page's contents must fit the screen in Portrait Mode in any language.

English Japanese
1 2

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.63 (177)
BraveCore: 1.63.177 (122.0.6261.128)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details:

iPhone 14 / iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@hffvld hffvld added bug QA/Yes OS/iOS Fixes related to iOS browser functionality browser-ai labels Mar 15, 2024
@hffvld hffvld added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 15, 2024
@kjozwiak kjozwiak added this to the 1.63.x - Release #6 milestone Mar 15, 2024
@kjozwiak
Copy link
Member

Adding release/blocking after discussing with @mattmcalister. As mentioned, Germany & France are major/popular regions for us.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 18, 2024

The above requires 1.63.178 or higher for 1.63.x verification 👍As mentioned via brave/brave-core#22627 (comment), the multiline issue will be addressed in a follow up release.

As per the conversation via https://bravesoftware.slack.com/archives/C05NDQP03AQ/p1710531689040729, we're going to live with the string taking up two lines rather than a single line for the initial release but will address the issues via #36870 & #36871.

@kjozwiak
Copy link
Member

Using the STR/Cases outlined via #36856 (comment), ensured that the string/text isn't being cut off on certain locales such as German & Russian.

German

Example Example
IMG_0151 IMG_0152

Russian

Example Example
IMG_0153 IMG_0154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai bug OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release/blocking release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants