Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.63 translations #36723

Closed
iccub opened this issue Mar 12, 2024 · 3 comments · Fixed by brave/brave-core#22590
Closed

Add 1.63 translations #36723

iccub opened this issue Mar 12, 2024 · 3 comments · Fixed by brave/brave-core#22590
Assignees
@iccub
Labels
enhancement OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.63.x - Release #6

Comments

@iccub
Copy link

iccub commented Mar 12, 2024 •
edited
Loading

Test Plan:

  • Change language to non english

Verify that Leo screens are translated
@iccub iccub added enhancement release-notes/exclude OS/iOS Fixes related to iOS browser functionality labels Mar 12, 2024
@iccub iccub added this to the 1.63.x - Release #5 milestone Mar 12, 2024
iccub added a commit to brave/brave-core that referenced this issue Mar 13, 2024
@iccub
[iOS] Add 1.63 translations.
4ff2661 
Resolves brave/brave-browser#36723
@iccub iccub mentioned this issue Mar 13, 2024
Merged
24 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 13, 2024
@iccub
[iOS] Add 1.63 translations. (#22572)
22238e4 
* [iOS] Add 1.63 translations.

Resolves brave/brave-browser#36723

* Review
@kjozwiak
Copy link
Member

@iccub mind add some info/context re: which area's QA should concentrate on in terms? Or is this a general pass like we usually do every release?

@kjozwiak kjozwiak mentioned this issue Mar 13, 2024
Closed
26 tasks
@iccub
Copy link
Author

iccub commented Mar 14, 2024

Added test plan

@iccub iccub self-assigned this Mar 14, 2024
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations.
bd5830f 
Resolves brave/brave-browser#36723
@iccub iccub mentioned this issue Mar 14, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations.
00469e8 
Resolves brave/brave-browser#36723
@iccub iccub mentioned this issue Mar 14, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations.
174cc60 
Resolves brave/brave-browser#36723
@iccub iccub mentioned this issue Mar 14, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations. (Downlift to master) (#22590)
738dead 
[iOS] Add 1.63 translations.

Resolves brave/brave-browser#36723
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations. (Downlift to 1.65.x) (#22595)
6f6b25d 
[iOS] Add 1.63 translations.

Resolves brave/brave-browser#36723
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 14, 2024
@iccub
[iOS] Add 1.63 translations. (Downlift to 1.64.x) (#22589)
0fd647b 
[iOS] Add 1.63 translations.

Resolves brave/brave-browser#36723
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 15, 2024
@hffvld
Copy link
Contributor

hffvld commented Mar 15, 2024 •
edited
Loading

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.63 (177)
BraveCore: 1.63.177 (122.0.6261.128)

Filed follow-up issue #36856

STEPS:

  1. Switch device to Non-English language
  2. Launch Brave
  3. Open Leo > Verify translation on multiple screens

ACTUAL RESULTS:

  • Verified Leo UI translation with Russian, Spanish, French, German and Japanese
Russian
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Spanish
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
French
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
German
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Japanese
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld mentioned this issue Mar 15, 2024
Closed
@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
enhancement OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.63.x - Release #6
Development

Successfully merging a pull request may close this issue.

[iOS] Add 1.63 translations. (Downlift to master) brave/brave-core
3 participants
@kjozwiak @iccub @hffvld