Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add 1.63 translations. (Downlift to master) #22590

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Mar 14, 2024

Resolves brave/brave-browser#36723

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iccub iccub added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 14, 2024
@iccub iccub requested a review from a team as a code owner March 14, 2024 11:38
Copy link
Contributor

[puLL-Merge] - brave/brave-core@22590

Here is my review of the pull request:

Description

This PR adds new localized string resources for various languages in the Brave iOS app. It includes translations for strings related to the Brave wallet, AI chat, and Brave shields.

Changes

Changes

  • Added new .strings files for multiple languages under ios/brave-ios/Sources/AIChat/Resources, ios/brave-ios/Sources/BraveShields/Resources, ios/brave-ios/Sources/BraveStrings/Resources, and ios/brave-ios/Sources/BraveWallet/Resources
  • Languages added include de, es, fr, id-ID, it, ja, ko-KR, ms, nb, pl, pt-BR, ru, sv, tr, uk, zh-TW, and zh

Security Hotspots

None identified. Adding localized string resources does not introduce security risks. The translations should be reviewed for accuracy, but do not pose a direct security threat.

@iccub iccub merged commit 738dead into master Mar 14, 2024
20 checks passed
@iccub iccub deleted the 36723_master branch March 14, 2024 17:45
@github-actions github-actions bot added this to the 1.66.x - Nightly milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1.63 translations
2 participants