-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A-C/Monthly Tips computation issue (leading to incorrect notifications) #3707
Labels
bug
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
mandar-brave
added
bug
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
labels
Mar 13, 2019
19 tasks
jasonrsadler
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 13, 2019
Add verified tips calculation into notification Add test for GetAmountFromVerifiedAuto Fix lint lint fixes Adding tests Combined tests to create WillTriggerNotification test spacing Updated methods to static
jasonrsadler
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 18, 2019
Add verified tips calculation into notification Add test for GetAmountFromVerifiedAuto Fix lint lint fixes Adding tests Combined tests to create WillTriggerNotification test spacing Updated methods to static
jasonrsadler
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 24, 2019
Add verified tips calculation into notification Add test for GetAmountFromVerifiedAuto Fix lint lint fixes Adding tests Combined tests to create WillTriggerNotification test spacing Updated methods to static Updated logic and test case for no publishers and zero balance lint
jasonrsadler
pushed a commit
to brave/brave-core
that referenced
this issue
May 24, 2019
jasonrsadler
pushed a commit
to brave/brave-core
that referenced
this issue
May 28, 2019
Verified passed with
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
For monthly recurring contributions, the only BAT that needs to be counted is;
a) for verified publishers in a-c
b) for verified publishers in Tip table
In any circumstance, the unverified pending BAT should not be counted for reconcile date contributions.
Issue: currently a lot of folks are getting incorrect notifications that they don't have sufficient funds for their monthly contribution when they do.
cc @NejcZdovc @jasonrsadler @LaurenWags @rebron
The text was updated successfully, but these errors were encountered: