Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-contribute fails due to unpaid non-signed up creators #4090

Closed
fmarier opened this issue Apr 12, 2019 · 7 comments · Fixed by brave/brave-core#2208
Closed

Auto-contribute fails due to unpaid non-signed up creators #4090

fmarier opened this issue Apr 12, 2019 · 7 comments · Fixed by brave/brave-core#2208

Comments

@fmarier
Copy link
Member

fmarier commented Apr 12, 2019

Test Plan

brave/brave-core#2208

This is similar to #4050, but on a different machine (work laptop) and on Beta instead of Release:

Brave | 0.63.35 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision | 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS | Linux

I got the following "insufficient funds" error:

insufficient-funds

even though I have enough BATs in my grants wallet:

wallet

to cover my monthly allowance:

autocontribute-settings

Here's the complete brave://rewards page:

brave-rewards

@fmarier
Copy link
Member Author

fmarier commented Apr 12, 2019

@NejcZdovc did I provide enough info this time?

@NejcZdovc
Copy link
Contributor

yeah, this is great. Looks like that #3640 didn't fix it. We will need to add balance fetch for notifications as well

@LaurenWags
Copy link
Member

@NejcZdovc looks like brave/brave-core#2115 (fix for #3640) wasn't merged to 0.63.x, could that be why this is occurring?

@NejcZdovc
Copy link
Contributor

this is one and we had another fix for it #4115

@rebron
Copy link
Collaborator

rebron commented Apr 25, 2019

brave/brave-core#2115 got merged into 63.x and #4115 was merged into 65.x.
This should be fixed in 65.x then?

@NejcZdovc
Copy link
Contributor

@rebron this one will completely solve it #3707

jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 14, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 14, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 16, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 20, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 21, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2019

Verified passed with

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment