Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leo shortcut to URL bar microphone #38089

Closed
SergeyZhukovsky opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23534
Closed

Add Leo shortcut to URL bar microphone #38089

SergeyZhukovsky opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23534
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented May 6, 2024

We want to open Leo's chat window with a text from dictation on URL bar microphone tap.
Let's make it for English locale only currently and detect if the phrase starts with Leo. For example:

  1. Leo, what time is it now - opens a chat window with a prompt what time is it now.
  2. Leo - brings up a chat window without anything filled in a prompt Edit box.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality browser-ai labels May 6, 2024
@SergeyZhukovsky SergeyZhukovsky moved this to In Progress in Browser AI May 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI May 9, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 9, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 2, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 2, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 AP31.240517.031 release-keys
Brave build: 1.68.101
Chromium: 126.0.6478.126 (Official Build) beta (64-bit) 

Filed follow-up issue #39534

STEPS:

  1. Follow the STR/TP from Add Leo shortcut to URL bar microphone #38089 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the phrase Leo, what time is it now - opens a chat window with a prompt what time is it now
  • Verified that the phrase Leo - brings up a chat window without anything filled in a prompt Edit box
  • Verified that the phrase Hi Leo is not triggering Leo chat to be opened, even if the phrase contains Leo word

Galaxy Tab S8

2024-07-02_11-59-47.mp4

Pixel 7

2024-07-02_10-55-42.mp4
2024-07-02_11-00-17.mp4
2024-07-02_11-18-52.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants