Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Rewards Grants: Expiry date change #4042

Closed
mandar-brave opened this issue Apr 8, 2019 · 2 comments · Fixed by brave/brave-core#2182
Closed

Ads Rewards Grants: Expiry date change #4042

mandar-brave opened this issue Apr 8, 2019 · 2 comments · Fixed by brave/brave-core#2182

Comments

@mandar-brave
Copy link

Any grants received via the server that below to Ads Rewards should have no expiry date.

When the grants show up;
a) they should show up as grants (no change)
b) but no expiry date should be displayed (the ask)

These grants will be signed for a really long period of time; but for the moment the BR wallet should not show the grants timetable.

Existing grants, that are not ads rewards, will continue to work the same.

@NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/ads labels Apr 8, 2019
@mandar-brave
Copy link
Author

@rebron needs uplift for 0.63 to ensure there is no confusion at the user end. Very minor change.

@NejcZdovc NejcZdovc added this to the 0.63.x - Beta milestone Apr 9, 2019
NejcZdovc added a commit to brave/brave-ui that referenced this issue Apr 9, 2019
NejcZdovc added a commit to brave/brave-ui that referenced this issue Apr 9, 2019
@NejcZdovc NejcZdovc self-assigned this Apr 9, 2019
NejcZdovc added a commit to brave/brave-ui that referenced this issue Apr 9, 2019
NejcZdovc added a commit to brave/brave-ui that referenced this issue Apr 10, 2019
NejcZdovc added a commit to brave/brave-ui that referenced this issue Apr 10, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 10, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Apr 18, 2019

Verified passed with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#2182

Ads grant has not expiration date
image

UGP grants still display expiration date
image

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

Token Grant with expiry date
Screenshot from 2019-04-18 20-01-16
Screenshot from 2019-04-18 20-01-30
Ad grant without expiry date
Screenshot from 2019-04-18 20-02-18
Screenshot from 2019-04-18 20-02-28
Encountered #4169
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants