-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hides expiry date for ads #2182
Conversation
51be23c
to
4036e4f
Compare
73c5c14
to
994119e
Compare
@@ -156,9 +156,14 @@ class PageWallet extends React.Component<Props, State> { | |||
} | |||
|
|||
return grants.map((grant: Rewards.Grant) => { | |||
let expireDate = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: same logic is used in a couple places, consider decoupling into a method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only use it here for the settings page, sadly extension code has different util files
Resolves brave/brave-browser#4042
UI implementation: brave/brave-ui#444
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
plan 2:
Reviewer Checklist: