Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Brave Pay"/Brave Account text #4076

Closed
rebron opened this issue Apr 11, 2019 · 2 comments · Fixed by brave/brave-core#2227
Closed

remove "Brave Pay"/Brave Account text #4076

rebron opened this issue Apr 11, 2019 · 2 comments · Fixed by brave/brave-core#2227

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 11, 2019

Test plan

  1. Visit brave://settings/payments
  2. Ensure To add or manage Brave Pay payment methods, visit your Brave Account does NOT show (see picture below for example)

Description

C74 update included text that doesn't belong. Need to remove the following text:

"To add or manage Brave Pay payment methods, visit your Brave Account"
from:
brave://settings/payments

Screen Shot 2019-04-11 at 4 38 23 PM

Expected result:

Text above isn't displayed at all.

Brave version (brave://version info)

0.63.35 Chromium: 74.0.3729.61

Reproducible on current release:

  • Not in release builds (62.x), currently only 63.x and above.
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. branding labels Apr 11, 2019
@LaurenWags
Copy link
Member

Encountered this issue while testing #4033 on macOS

Brave 0.63.35 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Mac OS X

@LaurenWags
Copy link
Member

LaurenWags commented Apr 18, 2019

Verified passed with

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X
  • Verified STR from description

Screen Shot 2019-04-18 at 3 57 39 PM

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

image

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants