Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the To add or manage payment methods section #2227

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#4076

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

See brave/brave-browser#4076

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton added this to the 0.65.x - Nightly milestone Apr 16, 2019
@bsclifton bsclifton requested review from petemill and mkarolin April 16, 2019 00:49
@bsclifton bsclifton self-assigned this Apr 16, 2019
@bsclifton
Copy link
Member Author

@petemill I figured a patch would be easier- but we could do this with the new patching system you had put together. Let me know if you'd like me to give that a go

@bsclifton bsclifton force-pushed the bsc-remove-brave-pay-text branch from 058de13 to 8c4c4ef Compare April 16, 2019 08:05
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use the new RegisterPolymerTemplateModifications function via settings_overrides.js, you could do something like:

{
	'settings-payments-section': function(templateContent) {
		const manageLink = templateContent.querySelector('#manageLink')
		if (!manageLink) {
			throw new Error('[Brave Settings Overrides] Could not find manage payments link')
		}
		manageLink.remove()
	}
}

@bsclifton bsclifton force-pushed the bsc-remove-brave-pay-text branch from 8c4c4ef to a57cebe Compare April 16, 2019 23:08
@bsclifton
Copy link
Member Author

@petemill updated! 😄Love doing it this way

@petemill petemill force-pushed the bsc-remove-brave-pay-text branch from a57cebe to 5836c49 Compare April 17, 2019 21:29
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@bsclifton bsclifton merged commit 7498930 into master Apr 17, 2019
@bsclifton bsclifton deleted the bsc-remove-brave-pay-text branch April 17, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "Brave Pay"/Brave Account text
2 participants