-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads are enabled by default after update to 0.63.x #4131
Labels
bug
feature/ads
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/blocking
release-notes/exclude
Milestone
Comments
jsecretan
added
priority/P1
A very extremely bad problem. We might push a hotfix for it.
release/blocking
labels
Apr 16, 2019
Reproduced on
|
19 tasks
@LaurenWags this issue will be resolved as part of #3967 and #4154 |
tmancey
added a commit
to brave/brave-core
that referenced
this issue
Apr 17, 2019
…update to 0.63.x fixes brave/brave-browser#3967 fixes brave/brave-browser#4131
3 tasks
This was referenced Apr 18, 2019
Verified passed with
Verification PASSED on
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/ads
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/blocking
release-notes/exclude
Description
When you update from a version where Ads is not available, the Ads toggle gets turned on without user choice.
Steps to Reproduce
Another way to reproduce is:
Actual result:
Ads is toggled to on and Ads will begin being served to user.
Expected result:
Ads should not be toggled on.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
n/a, Ads not enabled on current release
Website problems only:
Additional Information
cc @jsecretan @brave/legacy_qa
The text was updated successfully, but these errors were encountered: