Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoring a wallet does not check for grant #4220

Closed
LaurenWags opened this issue Apr 24, 2019 · 2 comments · Fixed by brave/brave-core#2372
Closed

restoring a wallet does not check for grant #4220

LaurenWags opened this issue Apr 24, 2019 · 2 comments · Fixed by brave/brave-core#2372

Comments

@LaurenWags
Copy link
Member

Description

After a wallet is restored, it doesn't appear as though there is a check for grant. No notification appears on BAT logo and no claim banner displays on brave://rewards.

Steps to Reproduce

  1. Launch Brave (I used staging flag)
  2. Enable Rewards. (Since I was on staging, there was a grant notification. I claimed it for the wallet that had been created, this made the claim banner go away on brave://rewards).
  3. Restore a wallet (staging one if necessary).
  4. Wallet is restored, but no notification to accept a grant. If you refresh page then you will see the claim banner.

Actual result:

No claim banner/notification about UGP grant

Expected result:

Claim banner/notification

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure, probably yes
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@btlechowski
Copy link

Not reproducible on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Steps used:

  1. Clean install
  2. Run with staging flag
  3. Enable rewards, make sure grant is available
  4. Backup wallet through keys
  5. Clean install
  6. Enable rewards and claim grant
  7. Restore wallet from 4.

image

@LaurenWags Maybe your restored wallet didn't have grants available?

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 1, 2019
@ryanml ryanml added this to the 0.66.x - Nightly milestone May 6, 2019
@ryanml ryanml self-assigned this May 6, 2019
ryanml added a commit to brave/brave-core that referenced this issue May 7, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 10, 2019

Verification passed on

Brave 0.67.105 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description

Verified passed with

Brave 0.67.107 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
  • Verified STR from description

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants