-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetches grants after wallet recovery #2372
Conversation
@ryanml recovery response should return grants as you can see here https://github.com/brave/brave-core/pull/2372/files#diff-2e09ca2971f3a4e74fb753ef2fca3113R133. Let's try to figure out why grants are not correct instead of adding another get |
@NejcZdovc those are assigned under walletInfo, which are grants already claimed. We need to get grants available for claiming, which exists at the top level of the state. |
@ryanml sounds good |
@ryanml could you please add unit test for this reducer |
Removes unused args for grant fetch
Fixes: brave/brave-browser#4220
This also removes arguments that were never being used for the
RewardsService::FetchGrants
call.Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.