Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetches grants after wallet recovery #2372

Merged
merged 1 commit into from
May 8, 2019
Merged

Fetches grants after wallet recovery #2372

merged 1 commit into from
May 8, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 6, 2019

Fixes: brave/brave-browser#4220

This also removes arguments that were never being used for the RewardsService::FetchGrants call.

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor

@ryanml recovery response should return grants as you can see here https://github.com/brave/brave-core/pull/2372/files#diff-2e09ca2971f3a4e74fb753ef2fca3113R133. Let's try to figure out why grants are not correct instead of adding another get

@ryanml
Copy link
Contributor Author

ryanml commented May 6, 2019

@NejcZdovc those are assigned under walletInfo, which are grants already claimed. We need to get grants available for claiming, which exists at the top level of the state.

@NejcZdovc
Copy link
Contributor

@ryanml sounds good

@NejcZdovc
Copy link
Contributor

@ryanml could you please add unit test for this reducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restoring a wallet does not check for grant
2 participants