Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Panel not updated with publisher info after enabling Rewards #4232

Closed
btlechowski opened this issue Apr 25, 2019 · 1 comment · Fixed by brave/brave-core#2453
Closed

Brave Panel not updated with publisher info after enabling Rewards #4232

btlechowski opened this issue Apr 25, 2019 · 1 comment · Fixed by brave/brave-core#2453
Assignees
@jasonrsadler
Labels
feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.67.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Apr 25, 2019 •
edited
Loading

Steps to Reproduce

  1. Enable rewards
  2. Disable rewards
  3. Open https://kjozwiak.github.io/
  4. Enable rewards through Rewards Panel

Actual result:

Publisher info is not shown in Rewards Panel

Note: Reopening Rewards Panel fixes the issue

4232

Expected result:

Publisher info is shown in Rewards Panel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @NejcZdovc @ryanml
@NejcZdovc NejcZdovc self-assigned this May 1, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 1, 2019
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc May 16, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 16, 2019
Fixes brave/brave-browser#4232
3046f5f
@jasonrsadler jasonrsadler mentioned this issue May 16, 2019
Merged
28 tasks
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 17, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Publisher data is now shown in panel after re-enabling Rewards from panel brave/brave-core
5 participants
@NejcZdovc @jasonrsadler @LaurenWags @btlechowski @GeetaSarvadnya