Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher data is now shown in panel after re-enabling Rewards from panel #2453

Merged
merged 1 commit into from
May 17, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented May 16, 2019

Fixes brave/brave-browser#4232

Submitter Checklist:

Test Plan:

  1. Start Brave and enable Rewards
  2. Disable Rewards
  3. Visit a web site
  4. In same tab with visited web site, enable Rewards from panel
  5. Ensure publisher data displays in panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Panel not updated with publisher info after enabling Rewards
2 participants