-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent crash if Confirmations library is called before being instantiated #4370
Conversation
9fc4936
to
f219e3b
Compare
vendor/bat-native-ledger/src/bat/ledger/internal/ledger_impl.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/ledger_impl.cc
Outdated
Show resolved
Hide resolved
3dfcfae
to
268cb47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewards code looks good, didn't check other things
Resolves Android crashes 1, 3, 5 and 6 for https://github.com/brave/browser-android-tabs/issues/2435 (which can also affecteds desktop users) |
Verified passed with
Clean profile:
Recovered wallet:
Toggling Ads off/on:
Existing/Upgraded profile:
|
Fixes brave/brave-browser#7728
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
QA will also run through the following which also includes manual passes for ads:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.